New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate string literal from macro #5116

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
4 participants
@hasnainvirk
Contributor

hasnainvirk commented Sep 15, 2017

From C++11 and beyond string literals must be seperated by space
so that they are recongizable as seperate tokens.

Context macro in PPPCellularInterface (CTX) has been causing issues
as it was not augmented with a space from a nearby string literal.

Seperatig string literal from macro
From C++11 and beyond string literals must be seperated by space
so that they are recongizable as seperate tokens.

Context macro in PPPCellularInterface (CTX) has been causing issues
as it was not augmented with a space from a nearby string literal.
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 15, 2017

@MarceloSalazar @adbridge mbed-os-example-cellular has been failing with IAR for MTS_DRAGINFLY_F411RE due to errors in PPPCellularIterface.cpp. I think an attempt was made to fix this by Deepika but it was incomplete.
Fixed in this commit. @karsev Here is the solution to your problem.

@theotherjimmy theotherjimmy changed the title from Seperatig string literal from macro to Separate string literal from macro Sep 15, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 15, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 16, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1320

All builds and test passed!

@adbridge adbridge self-requested a review Sep 18, 2017

@theotherjimmy theotherjimmy merged commit a0d5503 into ARMmbed:master Sep 18, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment