New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetis RTC HAL: Allow writing 0 to the seconds register #5152

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
5 participants
@mmahadevan108
Contributor

mmahadevan108 commented Sep 20, 2017

There is no hardware limitation in writing a 0 value to the seconds register.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 20, 2017

@0xc0170

I believe KLxxx have the same t == 1 condition

@mprse

This comment has been minimized.

Member

mprse commented Sep 21, 2017

@mmahadevan108 @0xc0170
The following files are affected by this issue:
/m-bed/targets/TARGET_Freescale/TARGET_K20XX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_KLXX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/api/rtc_api.c
/m-bed/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/api/rtc_api.c

Maybe we should also clear potential overflow/invalid flags after RTC time is set to 0?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 21, 2017

The following files are affected by this issue:
/m-bed/targets/TARGET_Freescale/TARGET_K20XX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_KLXX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/api/rtc_api.c
/m-bed/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/api/rtc_api.c

@mmahadevan108 Can you please fix all those RTC implementation within this patch?

RTC HAL: Allow writing 0 to the seconds register
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Update_RTC_HAL_driver branch to 1dadb05 Sep 21, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 21, 2017

Fixed the other RTC implementations as well.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1432

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 29, 2017

@theotherjimmy theotherjimmy merged commit f5bb15f into ARMmbed:master Sep 29, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Update_RTC_HAL_driver branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment