New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LPC54608 to LPC546XX to include support for LPC54608/18/28 #5162

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
7 participants
@mmahadevan108
Contributor

mmahadevan108 commented Sep 21, 2017

Same code-base can support LPC54608/18/28 platform family.

Status

**READY

Todos

  • Tests
    mbed tests passed on the 54608 board.
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 21, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 21, 2017

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Sep 22, 2017

could you add ethernet_api.c?

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 22, 2017

I am working to add ethernet support as a separate PR.

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Support_LPC54618 branch 2 times, most recently Sep 22, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 29, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 30, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1447

Build Prep failed!

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Support_LPC54618 branch Sep 30, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Sep 30, 2017

Resolved conflicts.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1492

All builds and test passed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

@mmahadevan108 Could you change the sha of the last commit to kick out Circle CI? we'll retrigger testing after that.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Oct 2, 2017

@theotherjimmy I am not familiar how to do this, can you please provide more details.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

@mmahadevan108 You could run git commit --amend on the last commit in the series, without making any changes. Then you would force push, git push -f.

Change LPC54608 to LPC546XX to include support for LPC54608/18/28
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Support_LPC54618 branch to 880f106 Oct 2, 2017

@maclobdell

This comment has been minimized.

Contributor

maclobdell commented Oct 3, 2017

@theotherjimmy please kick off the tests and try to get this merged urgently and released in 5.6.2.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 3, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 3, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1513

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 2291644 into ARMmbed:master Oct 3, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Support_LPC54618 branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment