New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_F207ZG: Analogout improvement #5188

Merged
merged 3 commits into from Oct 23, 2017

Conversation

Projects
None yet
7 participants
@bcostm
Contributor

bcostm commented Sep 25, 2017

Description

  • Align the code with the STM32F0 devices.
  • Add initialization of the obj->handle.State variable (this solves the tests-api-analogout GCC_ARM issue)

Status

READY

Migrations

NO

ST_INTERNAL_REF 36562

targets/TARGET_STM/TARGET_STM32F2/analogout_device.c Outdated
void analogout_init(dac_t *obj, PinName pin)
{
DAC_ChannelConfTypeDef sConfig;
void analogout_init(dac_t *obj, PinName pin) {

This comment has been minimized.

@0xc0170

0xc0170 Sep 25, 2017

Member

Can you revert this code style change?

@0xc0170 0xc0170 added the needs: work label Sep 25, 2017

@bcostm

This comment has been minimized.

Contributor

bcostm commented Sep 26, 2017

There is another thing to make this test pass for GCC. I close this PR until a solution is found.

@bcostm bcostm closed this Sep 26, 2017

@sg- sg- removed the needs: work label Sep 26, 2017

@bcostm bcostm reopened this Oct 5, 2017

@0xc0170 0xc0170 added the needs: work label Oct 5, 2017

@bcostm bcostm force-pushed the bcostm:fix_dac_f207zg branch Oct 5, 2017

@bcostm bcostm changed the title from NUCLEO_F207ZG: Fix issue with tests-api-analogout and GCC_ARM to NUCLEO_F207ZG: Analogout improvement Oct 5, 2017

@bcostm

This comment has been minimized.

Contributor

bcostm commented Oct 5, 2017

Everything is OK now on my side.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2017

retest uvisor

targets/TARGET_STM/TARGET_STM32F2/analogout_device.c Outdated
{
}

void analogout_free(dac_t *obj) {

This comment has been minimized.

@0xc0170

0xc0170 Oct 10, 2017

Member

Can you fix please { - new line

This comment has been minimized.

@bcostm

bcostm Oct 10, 2017

Contributor

ok done

@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 10, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 10, 2017

bcostm added some commits Sep 25, 2017

NUCLEO_F207ZG: Fix issue with tests-api-analogout and GCC_ARM
Without this fix the tests-api-analogout test is fail with GCC_ARM.

@bcostm bcostm force-pushed the bcostm:fix_dac_f207zg branch to 02598d5 Oct 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 19, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 19, 2017

Build : SUCCESS

Build number : 268
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5188/

Skipping test trigger, missing label 'NEED CI'

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 19, 2017

This was triggered with needs: CI , as label is added re-triggering the job
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 19, 2017

Build : SUCCESS

Build number : 283
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5188/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 20, 2017

@0xc0170 are you happy with this after the review changes ?

@theotherjimmy

Reviewed by @0xc0170

@theotherjimmy theotherjimmy merged commit 3354327 into ARMmbed:master Oct 23, 2017

7 checks passed

AWS-CI uVisor Build & Test Success
Details
AWS-CI uvisor Test DIDNT RUN UVISOR TESTS
Details
Cam-CI uvisor Build & Test DIDNT RUN UVISOR TESTS
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:fix_dac_f207zg branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment