New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved STDIO_UART defines for UBLOX_EVK_ODIN_W2 #5192

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@andreaslarssonublox
Contributor

andreaslarssonublox commented Sep 25, 2017

Description

Moved STDIO_UART defines to targets.json for UBLOX_EVK_ODIN_W2 instead of hardcoded.
The default UART(D2/D8) can be overriden in mbed_app.json like this to use UART_3 instead:

"target_overrides": {
        "UBLOX_EVK_ODIN_W2": {
            "target.usb_tx": "D1",
            "target.usb_rx": "D0",
            "target.stdio_uart": "UART_3"
        }
}

Status

Should be reviewed and tested by @andrewc-arm to make sure it solves #5129

Migrations

NO

Related PRs

#5129

Todos

None

Deploy notes

None

Steps to test or reproduce

Have only run one test case to verify that it is still possible to run 'mbed test'.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2017

Should be reviewed and tested by @andrewc-arm to make sure it solves #5129

👍

Looks good to me

@andrewc-arm

This comment has been minimized.

andrewc-arm commented Sep 27, 2017

Thanks for enabling this.
Due to being busy, I was not able to test this actually. I will do so later.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

@andreaslarssonublox Could you rebase to resolve the conflict?

@andreaslarssonublox andreaslarssonublox force-pushed the andreaslarssonublox:ublox_move_stdio_uart_defines branch to 120c9ad Oct 2, 2017

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented Oct 2, 2017

Rebased @theotherjimmy

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

thanks! @0xc0170 Could you review?

@0xc0170

0xc0170 approved these changes Oct 4, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 4, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2017

@andrewc-arm Any update?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 7, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 7, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1541

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 9, 2017

@theotherjimmy theotherjimmy merged commit df484e7 into ARMmbed:master Oct 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andrewc-arm

This comment has been minimized.

andrewc-arm commented Oct 10, 2017

Sorry. There was massive 10-days holiday just finished and there are tons of other issues. I will get back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment