New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit libraries and tests from tools coverage numbers #5193

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@theotherjimmy
Contributor

theotherjimmy commented Sep 25, 2017

I noticed recently, that our coverage numbers changed when we updated a
package we depend on. This is nonsense. Our coverage numbers should
reflect only our code.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2017

Who else should review this change? How to compare between previous vs this patch?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Sep 26, 2017

@0xc0170 Uh, you should be able to run the coverage yourself with coverage run -m pytest tools/test && coverage report from the root of this repo. If you do that on master, you will see coverage numbers for the tests themselves, which are generally 100%. If you run the coverage report from this PR, then you will not see the coverage numebers for the tests.

@theotherjimmy theotherjimmy merged commit c063e25 into ARMmbed:master Sep 28, 2017

3 checks passed

Cam-CI uvisor Build & Test Success
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment