New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF5x: Don't allocate GPIOTE in DigitalIn #5207

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
4 participants
@nvlsianpu
Contributor

nvlsianpu commented Sep 27, 2017

The allocation of GPIOTE channels for DigitalIn is unwanted behavior.
This caused early run-out of GPIOTE channels for InterruptPin.
This patch replacing input configuration that is using gpiote driver by configuration that is
using gpio hal.

Fix for InterruptPin part of ct-test-shield test issue #5133

Fix: DigitalIn of nRF5x was allocating GPIOTE channel
The allocation of GPIOTE channels for DigitalIn is unwanted behavior.
This caused early run-out of channels for InterruptPin.
This patch replacing input configuration that is using gpiote driver by configuration that is
using gpio hal.
@nvlsianpu

This comment has been minimized.

Contributor

nvlsianpu commented Sep 27, 2017

I also checked that ci-shield tests: TESTS-ASSUMPTIONS-DIGITALIO, TESTS-API-BUSINOUT ,TESTS-API-DIGITALIO were executed successfully with this patch.

This PR combined witch #5200 are fixing #5133.

@0xc0170 0xc0170 added the needs: CI label Sep 27, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Sep 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1440

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 2, 2017

@theotherjimmy theotherjimmy merged commit 8a3abbc into ARMmbed:master Oct 2, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theotherjimmy theotherjimmy changed the title from Fix: DigitalIn of nRF5x was allocating GPIOTE channel to NRF5x: Don't allocate GPIOTE in DigitalIn Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment