New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analogin scaling for EFM32 target #5223

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
5 participants
@seppestas
Contributor

seppestas commented Sep 29, 2017

Fixes #5115.

analogin_read_u16 returns a value in the range 0x0000 - 0xFFF0
since the resolution of the ADC is 12 bits. However, in
analogin_read this value gets divided by 0xFFFF assuming the range
is 0x0000-0xFFFF. This causes a small error in the value returned by
AnalogIn::read for the EFM32 target.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 29, 2017

cc @stevew817 @akselsm

@seppestas seppestas force-pushed the seppestas:master branch Sep 29, 2017

@seppestas

This comment has been minimized.

Contributor

seppestas commented Sep 29, 2017

Hhm, I updated my commit to also change the comments, but apparently github didn't pick up on the forced push... probably a caching issue.

Fix analogin scaling for EFM32 target
Fixes #5115.

`analogin_read_u16` returns a value in the range `0x0000 - 0xFFF0`
since the resolution of the ADC is 12 bits. However, in
`analogin_read` this value gets divided by `0xFFFF` assuming the range
is `0x0000-0xFFFF`. This causes a small error in the value returned by
`AnalogIn::read` for the EFM32 target.

@seppestas seppestas force-pushed the seppestas:master branch to 81cc5a4 Sep 29, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2017

cc @stevew817 @akselsm

bump

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 10, 2017

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Oct 10, 2017

Approved.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

/morph test

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 104
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5223/

Triggering tests

/test mbed-os

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 12, 2017

@theotherjimmy theotherjimmy merged commit 2f25744 into ARMmbed:master Oct 13, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment