New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LowPowerTimer and nightly builds #5242

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
6 participants
@c1728p9
Contributor

c1728p9 commented Oct 3, 2017

If a LowPowerTimer is started and then goes out of scope then a deep sleep lock underflow can occur. This is because the the variable '_lock_deepsleep' is checked when starting the timer but is not checked in the destructor, which unconditionally releases the deep sleep lock. This bug was introduced in #5148

Fix sleep lock underflow in LowPowerTimer
If a LowPowerTimer is started and then goes out of scope then a
deep sleep lock underflow can occur. This is because the
the variable '_lock_deepsleep' is checked when starting the timer
but is not checked in the destructor, which unconditionally releases
the deep sleep lock.
@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 3, 2017

/morph test-nightly

@0xc0170

0xc0170 approved these changes Oct 3, 2017

@0xc0170 0xc0170 added the needs: CI label Oct 3, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 3, 2017

@tommikas I restarted jenkins CI , seems that its not updating the status here?

@tommikas

This comment has been minimized.

Contributor

tommikas commented Oct 3, 2017

It's actually still running. There was a bit of a queue built up.

@pan-

pan- approved these changes Oct 3, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 3, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1510

Test failed!

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 3, 2017

Nightly appears to be failing tests-mbed_drivers-ticker due to #5006. I think nightly builds on master have been broken since then.

Revert #5006 - Extends test set for Ticker class
This commit reverts commit c1c0f1e
because it causes nightly builds to fail. This is because extra tests
added in tests-mbed_drivers-ticker fail on some targets, such as the
KL46Z, MAX32625MBED, MAX32630FTHR, NCS36510, NRF51 and NRF52_DK.

@c1728p9 c1728p9 changed the title from Fix sleep lock underflow in LowPowerTimer to Fix LowPowerTimer and nightly builds Oct 3, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 3, 2017

Added a commit to revert #5006. With this, nightly builds should pass.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 3, 2017

/morph test-nightly

@c1728p9 c1728p9 referenced this pull request Oct 3, 2017

Merged

Fix deep sleep lock bugs #5220

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 3, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1515

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 373e6ab into ARMmbed:master Oct 4, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment