New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MPL by default for 6LoWPAN-ND. #5252

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
8 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Oct 4, 2017

In Thread network, MPL is already enabled so this causes
both to behave similarly.

This is part of fixes for ARMmbed/mbed-os-example-mesh-minimal#130

Status

In test

Migrations

NO

Related PRs

List related PRs against other branches:

ARMmbed/mbed-os-example-mesh-minimal#137

Todos

  • Tests

@SeppoTakalo SeppoTakalo requested review from kjbracey-arm, mikter and karsev Oct 4, 2017

Enable MPL by default for 6LoWPAN-ND.
In Thread network, MPL is already enabled so this causes
both to behave similarly.

@SeppoTakalo SeppoTakalo force-pushed the 6lowpan-enable-MPL branch to 720ebc1 Oct 4, 2017

@karsev

This comment has been minimized.

Contributor

karsev commented Oct 4, 2017

Verified!

@karsev

karsev approved these changes Oct 4, 2017

@0xc0170 0xc0170 added needs: review and removed needs: review labels Oct 4, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 5, 2017

@SeppoTakalo You mention that tests were added? Where did you add tests? If this is a fix, I would like to see a test so that we don't break it again.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 5, 2017

No, I did not add tests.
This was tested manually because it requires RF sniffer for verifying.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 6, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 11, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 91
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5252/

Triggering tests

/test mbed-os

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1564

Build failed!

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 11, 2017

/home/jenkins/mbed_jenkins_iar_01_b10/workspace/bm_wrap/1650/mbed-os/drivers/BusIn.cpp
02:42:06         [DEBUG] Return: 2
02:42:06         [DEBUG] Output: Fatal error[LMS001]: License check failed. Use the IAR License Manager to
02:42:06         [DEBUG] Output:           resolve the problem. 
02:42:06         [DEBUG] Output: Failed to obtain feature: "ARM.EW.COMPILER_STD"
02:42:06         [DEBUG] Output:           version: "1.11".
02:42:06         [DEBUG] Output: Feature cannot run anymore because the license
02:42:06         [DEBUG] Output:           expiration date is reached. Status code 0xc800100d.
02:42:06         [DEBUG] Output:           [LicenseCheck:2.15.2.J2938, RMS:8.5.1.2009, Feature:ARM.EW.COMPILER,
02:42:06         [DEBUG] Output:           Version:1.10]
02:42:06         [DEBUG] Output: Fatal error detected, aborting.
02:42:06         

@0xc0170
Please restart test-job once the license issue is resolved.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

Please restart test-job once the license issue is resolved.

Thanks, will do

@studavekar please check the latest run here

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 11, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1565

Build Prep failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

I should run just build, but as it was already nightly, restarting. The license should be OK now

/morph test-nightly

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 11, 2017

morph nightly is replaced by #5252 (comment) , so change looks good i guess will update the other pending status.

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1566

Test failed!

@0xc0170 0xc0170 removed the needs: CI label Oct 12, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 12, 2017

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 12, 2017

please the failure the job was cancalled #5252 (comment)

actual result #5252 (comment)

@theotherjimmy theotherjimmy merged commit 2a57d59 into master Oct 13, 2017

7 checks passed

Cam-CI uvisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@0xc0170 0xc0170 deleted the 6lowpan-enable-MPL branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment