New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Gap platform abstraction layer #5295

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
8 participants
@pan-
Member

pan- commented Oct 11, 2017

Description

Add an interface exposing the primitives needed to realize operations defined in
the GAP layer. Data types, event and function definitions follow closely HCI
commands and events defined in the Bluetooth specification.

This adapter shall be implemented by porters if they want to use the generic
implementation of the Gap implementation.

Status

READY

Migrations

NO

@pan-

This comment has been minimized.

Member

pan- commented Oct 11, 2017

@marcbonnici @nvlsianpu @apalmieriGH May you review this PR ?

Other will follows containing the implementation of the GenericGAP, an abstraction managing the GAP server and the pal::Gap implementation for the Cordio stack.

@pan- pan- changed the title from Gap platform abstraction layer to BLE: Gap platform abstraction layer Oct 11, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 114
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/test mbed-os

@pan- pan- added the component: ble label Oct 11, 2017

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 12, 2017

@tommikas Can you restart jenkins CI please here?

features/FEATURE_BLE/ble/pal/GapEvents.h Outdated
* Construct a new GapConnectionCompleteEvent.
*
* @param status Status of the operation: 0x00 in case of success otherwise
* the error code associated with the faillure.

This comment has been minimized.

@marcbonnici

marcbonnici Oct 12, 2017

'faillure' is misspelt

features/FEATURE_BLE/ble/pal/GapEvents.h Outdated
/**
* Report advertising from on or more LE device.

This comment has been minimized.

@marcbonnici
features/FEATURE_BLE/ble/pal/GapTypes.h Outdated
/**
* Construct advertising data from an array.
*
* @param input_value Reference to the array containing the advertising dat

This comment has been minimized.

@marcbonnici
features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* or RESOLVABLE_PRIVATE_ADDRESS_RANDOM_FALLBACK then the peer address
* parameters (type and address) will be used to find the local IRK.
*
* @param peer_address_type Address type of the peer.sw

This comment has been minimized.

@marcbonnici
features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* - A connection is created.
* - Time out in case of high duty cycle directed advertising.
*
* If the random address as not been set and the advertising parameter

This comment has been minimized.

@marcbonnici
features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* If the random address as not been set and the advertising parameter
* own_address_type is set to 0x01 then the procedure shall fail.
*
* If the random address as not been set and the advertising parameter

This comment has been minimized.

@marcbonnici

This comment has been minimized.

@marcbonnici

marcbonnici Oct 16, 2017

This still needs correcting.

features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* if initiator_policy use the whitelist.
*
* @param Address used by the advertiser in its advertising packets. Not
* usedif initiator_policy use the whitelist.

This comment has been minimized.

@marcbonnici
features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* @note The value returned can change over time.
*
* @return The number of entries that can be stored in the LE subsystem. It
* range from 0x01 tp 0xFF.

This comment has been minimized.

@marcbonnici

@pan- pan- force-pushed the pan-:GAP-platform-abstraction-layer branch Oct 12, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2017

Build : SUCCESS

Build number : 141
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/test mbed-os

@pan- pan- force-pushed the pan-:GAP-platform-abstraction-layer branch Oct 15, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 16, 2017

"@marcbonnici @nvlsianpu @apalmieriGH May you review this PR ?"
Any further update on this ? Looks like it needs re-review?

@pan-

This comment has been minimized.

Member

pan- commented Oct 16, 2017

I updated the PR according to @marcbonnici comments.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@marcbonnici - approved?

features/FEATURE_BLE/ble/pal/PalGap.h Outdated
* If the random address has not been set and the advertising parameter
* own_address_type is set to 0x01 then the procedure shall fail.
*
* If the random address as not been set and the advertising parameter

This comment has been minimized.

@marcbonnici

marcbonnici Oct 19, 2017

This still needs correcting.
"as" -> "has"

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

Anyone else for review?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 23, 2017

@pan- Could you correct the typo? then we can get this show on the road.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 31, 2017

@pan- Could you please address the comments

BLE: Adaptation interface of the GAP layer.
This interface expose the primitives needed to realize operations defined in
the GAP layer. Data types, event and function definitions follow closely HCI
commands and events defined in the Bluetooth specification.

@pan- pan- force-pushed the pan-:GAP-platform-abstraction-layer branch to 744abca Oct 31, 2017

@pan-

This comment has been minimized.

Member

pan- commented Oct 31, 2017

@adbridge I've addressed the comments.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 2, 2017

@studavekar did these build and test triggers get dropped?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 2, 2017

@theotherjimmy i don't see a morph command for 744abca.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 3, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 4, 2017

Build : SUCCESS

Build number : 434
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5295/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 6, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 8, 2017

@0xc0170 0xc0170 merged commit 82f5b58 into ARMmbed:master Nov 9, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build Build finished.
Details
ci-morph-exporter Build finished.
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 removed the ready for merge label Nov 9, 2017

@pan- pan- deleted the pan-:GAP-platform-abstraction-layer branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment