New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ble: generic event filter #5299

Merged
merged 4 commits into from Nov 22, 2017

Conversation

Projects
None yet
7 participants
@pan-
Member

pan- commented Oct 11, 2017

Description

This filter prevent events to be signaled multiple times to the upper layer. It
also signal events to a newly set event processor hook.

Previously filtering was made at the port level with that patch it is factored out at an higher level.

Status

READY

Migrations

BLE ports may be updated after this PR has been merged to benefit from the builtin filter. Note that existing code continue to work however it can be simplified.

Related PRs

#5296

Note

Diff can be found here: pan-/mbed@generic-access-service-abstraction-layer...pan-:ble-generic-event-filter

@pan-

This comment has been minimized.

Member

pan- commented Oct 11, 2017

@marcbonnici @nvlsianpu @apalmieriGH Could you review this PR ?

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 125
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5299/

Triggering tests

/test mbed-os

@pan- pan- referenced this pull request Oct 11, 2017

Merged

Ble pal event queue #5300

@pan- pan- added the component: ble label Oct 11, 2017

@mbed-ci

This comment has been minimized.

features/FEATURE_BLE/source/BLE.cpp Outdated
transport->processEvents();
}
void BLE::onEventsToProcess(const BLE::OnEventsToProcessCallback_t& callback)
{
whenEventsToProcess = callback;
// If events where previously signaled but the handler was not in place then

This comment has been minimized.

@marcbonnici

@pan- pan- force-pushed the pan-:ble-generic-event-filter branch Oct 12, 2017

@pan- pan- force-pushed the pan-:ble-generic-event-filter branch Oct 15, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@pan- any update? more work or ?

@pan-

This comment has been minimized.

Member

pan- commented Oct 19, 2017

None I'm aware of. That may help if it gets reviewed by others 😅 .

pan- added some commits Oct 11, 2017

BLE: Adaptation interface of the GAP layer.
This interface expose the primitives needed to realize operations defined in
the GAP layer. Data types, event and function definitions follow closely HCI
commands and events defined in the Bluetooth specification.
BLE: Generic Access Service Adaptation layer
Add an abstraction which manage the state of the GAP service exposed by the GATT server.
BLE: Add generic event filter.
This filter prevent events to be signaled multiple times to the upper layer. It
also signal events to a newly set event processor hook.

@pan- pan- force-pushed the pan-:ble-generic-event-filter branch to 63668cb Oct 31, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 14, 2017

@marcbonnici Can you review/approve this please?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 557
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5299/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit 23408e4 into ARMmbed:master Nov 22, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:ble-generic-event-filter branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment