New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ble pal event queue #5300

Merged
merged 5 commits into from Nov 30, 2017

Conversation

Projects
None yet
7 participants
@pan-
Member

pan- commented Oct 11, 2017

Description

To help generic code, an interface of an event queue at the PAL level has been added. Implementation can either rely on the event mechanism internal to the stack or use the SimpleEventQueue implementation provided by this patch.

Note: this is not a replacement of mbed event queue.

Status

READY

Related PRs

#5299

Note

Diff can be found here: pan-/mbed@ble-generic-event-filter...pan-:ble-pal-event-queue

@pan-

This comment has been minimized.

Member

pan- commented Oct 11, 2017

@marcbonnici @nvlsianpu @apalmieriGH Could you review this PR ?

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 131
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5300/

Triggering tests

/test mbed-os

@pan- pan- force-pushed the pan-:ble-pal-event-queue branch Oct 12, 2017

@pan- pan- force-pushed the pan-:ble-pal-event-queue branch Oct 15, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@marcbonnici @nvlsianpu @apalmieriGH Could you review this PR ?

bump

pan- added some commits Oct 11, 2017

BLE: Adaptation interface of the GAP layer.
This interface expose the primitives needed to realize operations defined in
the GAP layer. Data types, event and function definitions follow closely HCI
commands and events defined in the Bluetooth specification.
BLE: Generic Access Service Adaptation layer
Add an abstraction which manage the state of the GAP service exposed by the GATT server.
BLE: Add generic event filter.
This filter prevent events to be signaled multiple times to the upper layer. It
also signal events to a newly set event processor hook.
BLE: Event Queue interface at the pal level.
To help generic code, an interface of an event queue at the PAL level has been
added. Implementation can either rely on the event mechanism internal to the
stack or use the SimpleEventQueue implementation provided by this patch.

@pan- pan- force-pushed the pan-:ble-pal-event-queue branch to 953739c Oct 31, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 27, 2017

/morph build

@0xc0170 0xc0170 added the needs: CI label Nov 27, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 27, 2017

Build : SUCCESS

Build number : 602
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5300/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@pan-

This comment has been minimized.

Member

pan- commented Nov 28, 2017

Looking at the CI logs, the exporters failure is due to CI timeout. @0xc0170 Is it possible to relaunch exporter tests ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 28, 2017

/morph export-build

@mbed-ci

This comment has been minimized.

@pan-

This comment has been minimized.

Member

pan- commented Nov 28, 2017

Why that was aborted ? I'd appreciate if this is present in 5.7; the PR has been up since the 11th of October.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 28, 2017

One job timeouted , I'll notify Kevin

/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 28, 2017

@0xc0170 0xc0170 merged commit 9f8ac65 into ARMmbed:master Nov 30, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:ble-pal-event-queue branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment