New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Target: Mbed Connect Cloud board #5305

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
9 participants
@andcor02
Contributor

andcor02 commented Oct 12, 2017

Description

Introduced mbed Connect Cloud board based on ODIN-W2 Module
Renamed some UBLOX ODIN-W2 files to make space for new board,

ADDED ublox recent changes

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2017

Build : SUCCESS

Build number : 147
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/test mbed-os

@andcor02 andcor02 force-pushed the andcor02:master branch Oct 12, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 12, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2017

Build : SUCCESS

Build number : 149
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/test mbed-os

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 13, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 13, 2017

Build : SUCCESS

Build number : 167
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Skipping test trigger, missing label 'NEED CI'

@screamerbg

This comment has been minimized.

Member

screamerbg commented Oct 13, 2017

@andcor02 can you rebase please?

@andreaslarssonublox this would need your blessing :)

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented Oct 14, 2017

LGTM!

@andcor02 andcor02 force-pushed the andcor02:master branch Oct 16, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 18, 2017

/morph test

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@andcor02 Please look at the failure, it is related to this target, for ARM.

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Oct 19, 2017

@janjongboom

This comment has been minimized.

Contributor

janjongboom commented Oct 20, 2017

@andcor02, copy features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/ to features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/

This fixed it for me in ARMCC5

@andcor02 andcor02 force-pushed the andcor02:master branch Oct 20, 2017

@andcor02

This comment has been minimized.

Contributor

andcor02 commented Oct 20, 2017

Thanks for the help Jan! Pushed changes!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 23, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 23, 2017

Build : SUCCESS

Build number : 308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

@theotherjimmy theotherjimmy changed the title from New Target Mbed Connect Cloud board - redo! to New Target: Mbed Connect Cloud board Oct 23, 2017

@mbed-ci

This comment has been minimized.

@adbridge

Just a couple more minor tweaks, the rest looks ok

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_conf.c Outdated
.ReceiveFlowControl = ETH_RECEIVEFLOWCONTROL_DISABLE,
.TransmitFlowControl = ETH_TRANSMITFLOWCONTROL_DISABLE,
.VLANTagComparison = ETH_VLANTAGCOMPARISON_16BIT,
.VLANTagIdentifier = 0x0U, };

This comment has been minimized.

@adbridge

adbridge Oct 31, 2017

Contributor

@andcor02 Sorry to be a pain, the terminating brace should be on it's own line and directly underneath the E of ETH_MACInitTypeDef macconf . I don't think there should be a comma after the last entry either.

...nterface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/stm32f4_eth_conf.c Outdated
@@ -48,8 +47,7 @@ void _eth_config_mac(ETH_HandleTypeDef *heth)
.ReceiveFlowControl = ETH_RECEIVEFLOWCONTROL_DISABLE,
.TransmitFlowControl = ETH_TRANSMITFLOWCONTROL_DISABLE,
.VLANTagComparison = ETH_VLANTAGCOMPARISON_16BIT,
.VLANTagIdentifier = 0x0U,
};
.VLANTagIdentifier = 0x0U, };

This comment has been minimized.

@adbridge

adbridge Oct 31, 2017

Contributor

@andcor02 When I commented that the terminating brace should be underneath the ETH, I meant on it's own line and directly underneath the E of ETH_MACInitTypeDef macconf . I don't think there should be a comma after the last entry either.

This comment has been minimized.

@andcor02

andcor02 Oct 31, 2017

Contributor

See changes

introduced mbed Connect Cloud board based on ODIN-W2 Module rety comm…
…it, added ublox changes

Corrected error

Corrected error in targets json

Reworked JSON

Added lwip-eth to Connect ODIN removes ARM CC error

Fixed formating issues

Correct formating error in  .json

Indentation errors

@andcor02 andcor02 force-pushed the andcor02:master branch to 53c476a Oct 31, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 31, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 31, 2017

Build : SUCCESS

Build number : 401
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@adbridge

Some other minor possible updates and then we should be good to go.

memcpy((void*)&id, (void*)pTemp, 1);
if (id == 0xFF){
p++;

This comment has been minimized.

@adbridge

adbridge Nov 7, 2017

Contributor

p++ is done in both parts of the conditional. Would it be better to write as :

p++;
if (id != 0xFF){
    memcpy((void*)&len, (void*)p++, 1);
    p += len;
}

??

pTemp = increment(pTemp);
}
if (pFound != NULL) {
memcpy(_macAddr, pFound->data, 6);

This comment has been minimized.

@adbridge

adbridge Nov 7, 2017

Contributor

I assume the 6 is the size of the macAddr - could this be a #define then ?

_macRetrieved = 1;
}
}
memcpy(mac, _macAddr, 6);

This comment has been minimized.

@adbridge

adbridge Nov 7, 2017

Contributor

Same comment as above

@@ -25,8 +25,7 @@ static C029_OTP_Header *increment(C029_OTP_Header *pTemp)
if (id == 0xFF){

This comment has been minimized.

@adbridge

adbridge Nov 7, 2017

Contributor

Same comment as the one above about this conditional structure

@adbridge

This comment has been minimized.

Contributor

adbridge commented Nov 7, 2017

Last set of comments , purely possible improvements. Agreed they should go back to the maintainers of these files for inclusion in subsequent PRs. Thus accepting this one

@adbridge

This comment has been minimized.

Contributor

adbridge commented Nov 7, 2017

@studavekar Why has a new comment kicked off the CI again?! This is not right

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 7, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Nov 7, 2017

Looks like we have a possible genuine failure:
REALTEK_RTL8195AM (netsocket tests for all toolchains)

        [Error] mbed_config.h@60,90: 'WIFI_SSID' was not declared in this scope
        [Error] mbed_config.h@60,101: 'WIFI_PASSWORD' was not declared in this scope
        [Error] mbed_config.h@60,116: 'WIFI_SECURITY' was not declared in this scope
        [Error] mbed_config.h@60,131: 'WIFI_CHANNEL' was not declared in this scope
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 7, 2017

Yes, that is correct, #5445 - once CI is back again, this should get first in !

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 8, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 8, 2017

Build : SUCCESS

Build number : 455
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5305/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 9, 2017

/morph export-build

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Nov 9, 2017

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 47bae16 into ARMmbed:master Nov 10, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment