New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Check for toolchain and core support for Arm Compilers #5317

Merged
merged 3 commits into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Oct 13, 2017

Fixes #5266 when deployed to the online compiler
Fixes #5345

Also corrects offline compiling of uARM for every target that supports uARM but
not ARM.

TODO:

  • A test so that I can't break this again

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-arm-supported-check branch 2 times, most recently Oct 17, 2017

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-arm-supported-check branch to 4673fb6 Oct 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

@theotherjimmy tests addition only missing here?

@theotherjimmy theotherjimmy referenced this pull request Oct 19, 2017

Closed

uARM support #5345

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 19, 2017

@0xc0170 Correct.

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Oct 20, 2017

Please close #5345 as soon as this PR is merged
Thx

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 20, 2017

@jeromecoutant I updated the PR description to include the Fixes tag. #5345 will be closed when this PR is merged.

theotherjimmy added some commits Oct 20, 2017

Test the supported check in the ARM toolchains
They fail right now, Cores are not checked

@theotherjimmy theotherjimmy changed the title from Tools: Check for uARM support when compiling with uARM to Tools: Check for toolchain and core support for Arm Compilers Oct 20, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 20, 2017

@0xc0170 I added the tests. If Travis CI passes, then my implementation is correct.

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Oct 20, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 21, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 21, 2017

Build : SUCCESS

Build number : 307
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5317/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit ab8a8de into ARMmbed:master Oct 23, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment