New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC1768: Fix ETHMEM_SECTION placement for ARM #5322

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
7 participants
@chrissnow
Contributor

chrissnow commented Oct 15, 2017

Description

Ethernet on LPC1768 is broken in 5.6 as per #5298
This corrects the placement of Ethernet memory with the ARM compiler.

Status

READY

Migrations

NO

Related PRs

branch PR

Todos

Deploy notes

Steps to test or reproduce

Build the TCPSocket_Example with 5.5.7 and it will work, any 5.6\master will fail to get an IP, using static IP will still fail to work properly.

Fixes #5298

@chrissnow chrissnow referenced this pull request Oct 15, 2017

Closed

LPC1768: Ethernet #5298

@chrissnow chrissnow changed the title from Fix ETHMEM_SECTION placement for ARM on LPC1768 to LPC1768: Fix ETHMEM_SECTION placement for ARM Oct 15, 2017

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 16, 2017

@SeppoTakalo please review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 17, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 18, 2017

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 18, 2017

/morph uvisor-test

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2017

Build : SUCCESS

Build number : 237
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph uvisor-test

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@chrissnow

This comment has been minimized.

Contributor

chrissnow commented Oct 25, 2017

@0xc0170 CI seems to have got stuck?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 26, 2017

@chrissnow looks like this now needs a rebase unforntunately...

@adbridge adbridge added needs: work and removed needs: CI labels Oct 26, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 26, 2017

@0xc0170 CI seems to have got stuck?

We are currently seeing some failures with infrastrastructure, that should be resolved soon. Once conflict resolved, we will restart CI.

@chrissnow chrissnow force-pushed the chrissnow:LPC1768_LWIP branch to 1e53aac Oct 26, 2017

@chrissnow

This comment has been minimized.

Contributor

chrissnow commented Oct 26, 2017

Rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 26, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 343
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@chrissnow

This comment has been minimized.

Contributor

chrissnow commented Oct 26, 2017

Failed due to an unrelated NRF51 error.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 27, 2017

/morph test

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 2, 2017

@studavekar It looks like some of these "in progress" indicators are incorrect.

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Nov 2, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 2, 2017

@theotherjimmy fixed the status. possible reason for this is : KostyaSha/github-integration-plugin#215

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 3, 2017

/morph uvisor-test

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 8, 2017

/morph uvisor-test

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 8, 2017

Build : SUCCESS

Build number : 458
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 9, 2017

@alzix Please trigger uvisor for this patch (seems it is not active for us at the moment for some reason)

@0xc0170 0xc0170 merged commit c67d91a into ARMmbed:master Nov 9, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0xc0170 0xc0170 removed the ready for merge label Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment