New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional note on the HeapBlockDevice constructor block parameter #5337

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
5 participants
@kegilbert
Contributor

kegilbert commented Oct 18, 2017

ARMmbed/mbed-os-5-docs#287 (comment) brought up some ambiguity in the difference between the constructors in HeapBlockDevice. Added a small blurb to avoid having to go to the source to see what the difference is.

Does this sound more in line with what you were thinking for the block parameter description @sg-?

@kegilbert kegilbert requested review from sg- and geky Oct 18, 2017

@sg-

sg- approved these changes Oct 18, 2017

@geky

geky approved these changes Oct 18, 2017

@0xc0170 0xc0170 added the needs: CI label Oct 18, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2017

Build : SUCCESS

Build number : 220
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5337/

Triggering tests

/morph test
/morph uvisor-test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 18, 2017

/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 18, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@0xc0170 0xc0170 merged commit 0916605 into ARMmbed:master Oct 19, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment