New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainingBlockDevice: fix changing blocks address #5375

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
8 participants
@kegilbert
Contributor

kegilbert commented Oct 24, 2017

Change address subtraction when moving through block devices to be the size of the entire block device not the block size.

Change address subtraction when moving through block devices to be th…
…e size of the entire block device not the block size

@kegilbert kegilbert requested a review from geky Oct 24, 2017

@geky

geky approved these changes Oct 25, 2017

looks good to me

@0xc0170 0xc0170 added the needs: CI label Oct 25, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2017

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2017

@tommikas I noticed you restarted a job here, and resulted in an exception (few other jobs as well), please can you help resolving them?

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 25, 2017

@tommikas

This comment has been minimized.

Contributor

tommikas commented Oct 26, 2017

Restarted again. Exceptions like that are usually momentary hiccups rather than a systematic problem.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 26, 2017

@studavekar CI issue ?

18:34:03 ERROR: Error cloning remote repo 'origin'

I will restart morph build and see if it goes away..

/morph build

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 26, 2017

@studavekar said the problem should be resolved, rekicking off
/morph build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 26, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 345
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5375/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 26, 2017

@0xc0170 0xc0170 changed the title from Fix ChainingBlockDevice address logic when changing blocks to ChainingBlockDevice: changing blocks address fix Oct 26, 2017

@theotherjimmy theotherjimmy merged commit 27533ff into ARMmbed:master Oct 30, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theotherjimmy theotherjimmy changed the title from ChainingBlockDevice: changing blocks address fix to ChainingBlockDevice: fix changing blocks address Oct 30, 2017

@kegilbert kegilbert deleted the kegilbert:chainingbd-address-iter-fix branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment