New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race test: fix out of memory problem for NUCLEO_F070RB #5379

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
7 participants
@maciejbocianski
Member

maciejbocianski commented Oct 25, 2017

Description

This test cause out of memory error ("Operator new[] out of memory") when run on NUCLEO_F070RB with GCC_ARM compiler

Since there is no need to place Thread objects on heap, it was moved from heap to main stack.
In the result more heap memory is available for test purpose and "out of memory" problem doesn't occur anymore

Status

READY

Migrations

NO

@0xc0170 0xc0170 requested a review from c1728p9 Oct 25, 2017

@0xc0170 0xc0170 requested a review from jeromecoutant Oct 25, 2017

@0xc0170

The commit could be more descriptive. It moves threads from heap to stack, as it is not required to be in heap, therfore as a result, this fixes targets with more limited heap space (more generic fix).

@bulislaw

This comment has been minimized.

Member

bulislaw commented Oct 26, 2017

I don't we need more reviews for that, can we push it to next stage.

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Oct 30, 2017

| NUCLEO_F070RB-GCC_ARM | NUCLEO_F070RB | tests-mbed_drivers-race_test | OK | 16.43 | default |
| NUCLEO_F072RB-GCC_ARM | NUCLEO_F072RB | tests-mbed_drivers-race_test | OK | 16.2 | default |
| NUCLEO_L073RZ-GCC_ARM | NUCLEO_L073RZ | tests-mbed_drivers-race_test | OK | 18.96 | default |

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 30, 2017

/morph build

@adbridge adbridge added needs: CI and removed needs: review labels Oct 30, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 30, 2017

Build : SUCCESS

Build number : 366
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5379/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@adbridge adbridge added ready for merge and removed needs: CI labels Oct 31, 2017

@theotherjimmy theotherjimmy merged commit c7b4c7a into ARMmbed:master Nov 1, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment