New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlicingBD: replace second constructor with default parameter #5385

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
7 participants
@kegilbert
Contributor

kegilbert commented Oct 25, 2017

Slightly simplifies the SlicingBlockDevice constructor setup. Example in the header still works correctly.

@geky

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2017

@tommikas Can you look at the CI failure please, does look to me like internal error.

@tommikas

This comment has been minimized.

Contributor

tommikas commented Oct 26, 2017

Yep, Jenkins sometimes throws errors like that. Usually it's not systematic, and this too passed after restarting.

@0xc0170 0xc0170 requested a review from geky Oct 26, 2017

@0xc0170 0xc0170 changed the title from Replace second SlicingBlockDevice constructor with default end parameter to SlicingBlockDevice: constructor with default end parameter Oct 26, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 26, 2017

@kegilbert First line of the commit msg should not exceed 50 characters (I edited the headline here, please review). You can provide more information in the next paragraph in the commit msg.

Replace second SlicingBD ctor with default arg
Replace second ctor in SlicingBlockDevice with default parameter for the end address in first ctor

@kegilbert kegilbert force-pushed the kegilbert:slicingbd-ctor-rework branch to 84e3110 Oct 26, 2017

@kegilbert kegilbert changed the title from SlicingBlockDevice: constructor with default end parameter to SlicingBD: replace second constructor with default parameter Oct 26, 2017

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 26, 2017

@0xc0170 I updated the commit and title, thanks for the heads up!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 26, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 346
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5385/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@geky

geky approved these changes Oct 26, 2017

Looks good to me, yay a use for -0

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 26, 2017

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 26, 2017

Looks like all tests for the NCS36510 and NRF51_DK timed out.
@studavekar Should I rekick off the morph test?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 27, 2017

/morph test

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit 7b2e9b1 into ARMmbed:master Oct 30, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kegilbert kegilbert deleted the kegilbert:slicingbd-ctor-rework branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment