New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CallChain and InterruptManager #5393

Merged
merged 2 commits into from Nov 2, 2017

Conversation

Projects
None yet
7 participants
@c1728p9
Contributor

c1728p9 commented Oct 27, 2017

Deprecate the CallChain and InterruptManager classes since these are dead code which is not part of mbed-os's public API.

c1728p9 added some commits Oct 27, 2017

Deprecate InterruptManager
This patch deprecates the InterruptManager class since it is an
internal API (not in mbed.h) which is not being used anywhere in
the codebase.
Deprecate CallChain
This patch deprecates the CallChain class since it is an
internal API (not in mbed.h) and is only being used by
InterruptManager which is also deprecated.

@c1728p9 c1728p9 force-pushed the c1728p9:call_chain_deprecation branch to 891b06e Oct 27, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 27, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 27, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 27, 2017

Build : SUCCESS

Build number : 362
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5393/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci

This comment has been minimized.

@geky

geky approved these changes Oct 28, 2017

// class is deprecated already
#include "mbed_toolchain.h"
#undef MBED_DEPRECATED_SINCE
#define MBED_DEPRECATED_SINCE(...)

This comment has been minimized.

@geky

geky Oct 28, 2017

Member

Good idea 👍

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 2, 2017

Could we get another reviewer on this one?

@theotherjimmy theotherjimmy merged commit 6912a9d into ARMmbed:master Nov 2, 2017

5 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment