Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Python script to add cmsis/rtx changes in mbed-os #5407
Input to script is json in which user can list all folder/files need to picked up from CMSIS repository.
Drawback to SHA will be, conflicts which user will have to resolve themselves
Thanks Deepika, good starting point. Some comments though.
Can we rename the script to
tools/importer/cmsis.py? I think
tools/importer/cmsis_importer.py is a little redundant.
Why is this done differently than mbedtls and uvisor? Are there plans to align the way they import?
@deepikabhavnani Can you please provide an answer? As the example states uvisor/mbedtls could be used. Has this been synced with them, if this would satisfy their needs (they use own makefile to prepare a release that are referenced above in the comment).
@0xc0170 - Makefiles cannot be used for CMSIS/RTX as we have multiple patches/changes on top of original files. Suggestion was to use SHA for internal changes, instead of creating patch files.
Plan is to use this script for mbed-TLS and uVisior as well, but before that I want this to be fully functional for RTX/CMSIS.
Hi @deepikabhavnani !
First of all, thank you for your contribution!
As a Python lover, I think mbed's Python code could be greatly enhanced. Doing a huge PR at once is error prone so I try to use other people's PRs when possible to improve the quality. I have made a few suggestions to correct bugs and/or make your code more Pythonic.
PS: I don't know if your are an experienced Python dev, but I suggest you read the PEP8 which is a set of code style rules and use tools such as Pylint to check your code style and spot basic errors. This will improve the readability of your code and prevent basic bugs.
Naming nits asside, I would like to see the possibility of error handled in the
git checkout -b handled.
Build number : 542
Build number : 158