New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Update BatteryService documentation. #5472

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Nov 9, 2017

Description

Update documentation of ble Battery Service.

Status

READY

Migrations

NO

@pan-

This comment has been minimized.

Member

pan- commented Nov 9, 2017

@AnotherButler Could you review this documentation update ?

Copy edit BatteryService.h
Make minor copy edits, mostly for active voice and U.S. spelling.
@AnotherButler

Nice work on this 👍 It looks good.

@0xc0170 0xc0170 added the needs: CI label Nov 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 10, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 10, 2017

@pan- Can you verify build results ? [Error] BatteryService.h@103,21: 'level' was not declared in this scope being reported

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Nov 10, 2017

@pan-

This comment has been minimized.

Member

pan- commented Nov 10, 2017

@0xc0170 Fixed.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 10, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 10, 2017

Build : SUCCESS

Build number : 489
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5472/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 10, 2017

@studavekar Can you please look at the latest test report? The final report is success for the target that is reported as failed?

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 10, 2017

@0xc0170 looking at logs

00:19:15.827 mbedgt: test case summary: 7 passes, 0 failures
00:19:15.827 mbedgt: utest test case summary mismatch: utest reported passes and failures miscount!
00:19:15.827 	reported by utest: passes = 7, failures 0)
00:33:48.635 mbedgt: unexpected error:
00:33:48.636 	'utest_log'
00:33:48.636 Traceback (most recent call last):
00:33:48.637   File "/home/ci/jenkins_staging_7_NUCLEO_F401RE/workspace/tm_wrap/321/.env/bin/mbedgt", line 11, in <module>
00:33:48.637     load_entry_point('mbed-greentea', 'console_scripts', 'mbedgt')()
00:33:48.637   File "/home/ci/jenkins_staging_7_NUCLEO_F401RE/workspace/tm_wrap/321/greentea/mbed_greentea/mbed_greentea_cli.py", line 412, in main
00:33:48.637     cli_ret = main_cli(opts, args)
00:33:48.637   File "/home/ci/jenkins_staging_7_NUCLEO_F401RE/workspace/tm_wrap/321/greentea/mbed_greentea/mbed_greentea_cli.py", line 1063, in 

Issue : ARMmbed/greentea#246

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 14, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit b76b3f7 into ARMmbed:master Nov 16, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:doc_battery_service branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment