New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: update heart rate service definition. #5475

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Nov 10, 2017

Description

This patch includes:

  • Documentation update.
  • Code simplification and correctness; the value overloads based on the
    size of the hrm counter has been removed in favor of runtime check which
    is more correct.
  • The control point characteristic has been removed since HeartRate value
    byte does not support the accumulated energy expanded.

Status

READY

Migrations

NO

BLE: update heart rate service definition.
This patch includes:
* Documentation update.
* Code simplification and correctness; the value overloads based on the
  size of the hrm counter has been removed in favor of runtime check which
  is more correct.
* The control point characteristic has been removed since HeartRate value
  byte does not support the accumulated energy expanded.
@pan-

This comment has been minimized.

Member

pan- commented Nov 10, 2017

@0xc0170 Could you review the code update ?

@AnotherButler Could you review the documentation update ?

@0xc0170 0xc0170 requested a review from AnotherButler Nov 13, 2017

Copy edit HeartRateService.h
Make minor copy edits.
@AnotherButler

This looks awesome. 👍 I had very few changes. Nice work.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 14, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 14, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 14, 2017

Build : SUCCESS

Build number : 518
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5475/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Nov 14, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit bc92e40 into ARMmbed:master Nov 16, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:doc_heart_rate_service branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment