New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heap_and_stack test refactoring #5483

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
5 participants
@maciejbocianski
Member

maciejbocianski commented Nov 13, 2017

Description

Test refactoring and alignment to coding standards
Added test for main stack

Status

READY

Migrations

NO

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 13, 2017

@bulislaw @0xc0170 @c1728p9
What do you think about memory layout test?
Maybe we should create separate test suite for memory layout?

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:heap_and_stack_tests branch 2 times, most recently Nov 14, 2017

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 14, 2017

After discussion with @bulislaw we decided to remove memory layout test and take care of it later

@bulislaw

This comment has been minimized.

Member

bulislaw commented Nov 16, 2017

Yes, it's not good enough reason for us to ask partners (or do it ourselves) to update linker script for every platform for every compiler.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 16, 2017

@maciejbocianski Feel free to close this. Not sure if good enough reason for an issue , as this can be turned into an issue to capture all problems you found with this patch.

@0xc0170 0xc0170 added do not merge and removed needs: review labels Nov 16, 2017

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 17, 2017

@0xc0170 The problematic part of the test was removed.
Rest of the test is OK and ready to go
Please remove "do not merge" label

@0xc0170 0xc0170 requested a review from bulislaw Nov 17, 2017

@0xc0170 0xc0170 added needs: review and removed do not merge labels Nov 17, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Nov 17, 2017

Lets ignore the memory layout tests for now, I'm not sure there's good enough reason to mandate that for existing platforms. At least the ones that are failing.

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:heap_and_stack_tests branch to bc10335 Nov 20, 2017

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 20, 2017

TODO comment added : add memory layout test.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 20, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 559
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5483/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 21, 2017

@0xc0170
Fail is not connected to heap_and_stack test
Failing test: tests-netsocket-gethostbyname
Failing device: NUCLEO_F746ZG-IAR

[1511246558.84][HTST][INF] host test detected: default_auto 
[1511246620.47][CONN][RXD] :48::FAIL: Expected 0 Was -3010 
[1511246620.55][CONN][RXD] >>> failure with reason 'Assertion Failed' during 'Test Setup Handler'
@bulislaw

This comment has been minimized.

Member

bulislaw commented Nov 21, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 21, 2017

Build : SUCCESS

Build number : 563
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5483/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 21, 2017

An error has occurred. See the log file
/tmp/tmplo9Q1N/.metadata/.log.

SUCCESS
FAILURE

I can not see the failure and success at the same time. @maciejbocianski CAn you look at the log if you spot any error, its just one board and example blinky (not related but might be bug somewhere).

Retriggering at least once

/morph export-build

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Nov 21, 2017

Don't know how to access log.
The error looks like totally not connected to this PR

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 21, 2017

@theotherjimmy theotherjimmy merged commit cfa9e47 into ARMmbed:master Nov 22, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment