New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pack_* members to refer to PACK files #5489

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Nov 13, 2017

They referred to PDSC files before

At least a partial resolution to #5467
@rspelta @MarceloSalazar dose this resolve the error on import for you?
If so, does this correctly select the flash algorithm for you?

Correct pack_* members to refer to PACK files
They referred to PDSC files before
@rspelta

This comment has been minimized.

rspelta commented Nov 14, 2017

Hi, I tried with the version uvision 5.20 but this fix doesn't work. I have to try with the v5.24. At the moment my license is expired, I'm going to test it as soon as possible.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 14, 2017

@rspelta When you say that it dose not work, what exactly do you mean? This is meant to correct the dialog complaining about "PDSC Debug Description" and may not completely resolve tho problem.

@rspelta

This comment has been minimized.

rspelta commented Nov 15, 2017

I modified the mbed-os with your changes, and I exported the project as uvision5 (my v5.20) for SILICA_SENSOR_NODE but when I open the project I have still the window:

arm

with the message in the build output window:

File : C:\Keil_v5\ARM\PACK\Keil\STM32L4xx_DFP\2.0.0\Keil.STM32L4xx_DFP.pdsc
Sequence : CheckID
Context : Item #1:
Item #0: ::Line 2
Expression : " Message(2, "Not a genuine ST Device! Abort connection.");"
----------------------------^
E203 : Undefined identifier - function 'Message'

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 15, 2017

@rspelta That does not look like something I can fix (It seems to find the PDSC just fine). I'll contact my friends at Keil and see if we can track this down.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 15, 2017

Looking through the part of the sequence spec corresponding to the Message builtin function, the spec seems to indicate that it should be present on all implementations of the CMSIS PDSC spec. This may not be the case, and it may be that upgrading to Keil version 5.24 would correct that problem.

@rspelta

This comment has been minimized.

rspelta commented Nov 17, 2017

I find out a big problem. If you open the file .uvprojx you will find a line like:

<Device>STM32L476JG</Device>

It is wrong. The right name must be:

<Device>STM32L476JGYx</Device>

I changed it manually and the project now is ok. So we have to modify the export using the right name device for SILICA_SENSOR_NODE.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 17, 2017

@rspelta That's very odd. That part, STM32L476JG exists in the pack http://www.keil.com/pack/Keil.STM32L4xx_DFP.2.0.0.pack, and the part STM32L746JGYx does not exist.

From pack-manager.py:

$pack-manager find-part STM32L476JGYx
STM32L476JG
STM32L476G-EVAL

The closest match is STM32L476JG.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 17, 2017

from the PDSC file referenced in my previous comment:

        <!-- *************************  Device 'STM32L476JG'  ***************************** -->
        <device Dname="STM32L476JG">
          <memory id="IROM1"                               start="0x08000000" size="0x00100000" startup="1" default="1"/>
          <algorithm name="CMSIS/Flash/STM32L4xx_1024.FLM" start="0x08000000" size="0x00100000"             default="1"/>

          <variant Dvariant="STM32L476JGYx"> <feature type="CSP" n="72"/> </variant>
        </device>

It looks like uVision is expecting a variant here. I would have expecetd the <Device> tag to match the <device Dname= ... > attribute in the PDSC file.

@rspelta

This comment has been minimized.

rspelta commented Nov 22, 2017

I don't understand what we have to do now.
The export tool doesn't work correctly for the uvision5. Even if you try to export the project for another platform like NUCLEO_L476RG I have this error:

immagine

If I open the .uvprojx file and I edit the file from:

<Device>STM32L476RG</Device>

to

<Device>STM32L476RGTx</Device>

then uvision opens correctly the project.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 27, 2017

@rspelta I'm going to fix that problem in a following series of PRs. For now, this small PR fixes a small problem.


Long story

Presently, cmsis-pack-manager does not know anything about "variants" of "devices" in CMSIS Packs. To fix the problem you are having, I would need to update cmsis-pack-manager with an understanding of "variants" and then update targets.json to list the variant instead of the device in "device_name". That's a much bigger than 5 line change.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 30, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 1, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 1, 2017

Build : SUCCESS

Build number : 634
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5489/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Dec 1, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 1, 2017

@rspelta

This comment has been minimized.

rspelta commented Dec 12, 2017

Thank you! For me we can close this one.

@0xc0170 0xc0170 merged commit 1137b41 into ARMmbed:master Dec 12, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment