New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L072CZ_LRWAN1 can use LSE from LORA module #5512

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Nov 16, 2017

Description

DISCO_L072CZ_LRWAN1 can use LSE from LORA module

Status

READY

Test Result

+-------------------------+---------------------+-------------------------+----------------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-------------------------+---------------------+-------------------------+----------------------------------+--------+--------+--------+--------------------+
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_drivers-rtc | RTC strftime | 1 | 0 | OK | 10.93 |
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_hal-rtc_time | mk time | 1 | 0 | OK | 24.04 |
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_hal-rtc_time | test is leap year | 1 | 0 | OK | 0.04 |
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_hal-rtc_time | test local time | 1 | 0 | OK | 58.11 |
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_hal-rtc_time | test local time limits | 1 | 0 | OK | 0.05 |
| DISCO_L072CZ_LRWAN1-ARM | DISCO_L072CZ_LRWAN1 | tests-mbed_hal-rtc_time | test mk time out of range values | 1 | 0 | OK | 0.06 |
+-------------------------+---------------------+-------------------------+----------------------------------+--------+--------+--------+--------------------+

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 16, 2017

DISCO_L072CZ_LRWAN1 can use LSE from LORA module

What is this change fixing? Any changes we should be aware ? Would be nice to have this in the commit , why RTC_LSI is being removed.

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_L072 branch to 7635319 Nov 16, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 17, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 17, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 17, 2017

Build : SUCCESS

Build number : 544
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5512/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@bcostm

This comment has been minimized.

Contributor

bcostm commented Nov 17, 2017

why RTC_LSI is being removed

It's because the LSE (32 kHz) present in the module is more precise than the LSI. It will be much better for the LORA time server management.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 20, 2017

@theotherjimmy theotherjimmy merged commit 800be4e into ARMmbed:master Nov 20, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_L072 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment