New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retarget defines where possible #5528

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
5 participants
@c1728p9
Contributor

c1728p9 commented Nov 18, 2017

Remove the condition code around the defines in mbed_retarget.h so all toolchains use the defined values. Exclude a small subset of values for GCC since these are in its standard header files.

Use retarget defines where possible
Remove the condition code around the defines in mbed_retarget.h so
all toolchains use the defined values. Exclude a small subset of
values for GCC since these are in its standard header files.

@c1728p9 c1728p9 requested a review from geky Nov 18, 2017

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Nov 18, 2017

/morph build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 18, 2017

Build : SUCCESS

Build number : 548
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5528/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@geky

This comment has been minimized.

Member

geky commented Nov 22, 2017

Have you ran the incoming family tests over in the littlefs pr? They're probably the ones using these defines the most. If those pass I'm happy.

@theotherjimmy theotherjimmy merged commit 4b57c58 into ARMmbed:master Nov 22, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment