New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: SPI 3 wires mode not supported in SPI slave #5565

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
4 participants
@LMESTM
Contributor

LMESTM commented Nov 23, 2017

This patch handles the case of SPI slave mode without MISO (NC).
In case MISO is not connected, we consider that SPI will be configured in
3 wires mode (CLK / MOSI / CS, but no MISO). In this case, the MOSI line
is bi-directional : SPI_DIRECTION_1LINE.

But as this is not supported yet in slave mode, we force it to
SPI_DIRECTION_2LINES. In this case slave SPI will receive data on MOSI
but nothing will be sent back to master as MISO is not connected.

This FIX addresses the issue reported in: #5554

STM32: SPI 3 wires mode not supported in SPI slave
This patch handles the case of SPI slave mode without MISO (NC).
In case MISO is not connected, we consider that SPI will be configured in
3 wires mode (CLK / MOSI / CS, but no MISO). In this case, the MOSI line
is bi-directional : SPI_DIRECTION_1LINE.

But as this is not supported yet in slave mode, we force it to
SPI_DIRECTION_2LINES. In this case slave SPI will receive data on MOSI
but nothing will be sent back to master as MISO is not connected.

@0xc0170 0xc0170 added the needs: CI label Nov 24, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 24, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 24, 2017

Build : SUCCESS

Build number : 587
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5565/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 27, 2017

nucleo f429 time-outs for sleep lock, this does not seem related, at least one more retrigger to be certain this is master/this patch issue.

/morph test

@mbed-ci

This comment has been minimized.

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Nov 27, 2017

F429ZI was failing with bad flashes, updated some of the CI hardware to hopefully resolve the issue. Will kick off the test again in a minute.

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Nov 27, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 45e9e4c into ARMmbed:master Nov 30, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment