New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo? in e2studio exporter code #5657

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Dec 5, 2017

The update to the e2studio exporter in 2cbca70 was inconsistent about
it's naming of the "jinja context creation" function. This pull request
resolves that naming problem.

When deployed to the website, #5612 is resolved

@0xc0170

0xc0170 approved these changes Dec 5, 2017

@0xc0170 0xc0170 added the needs: CI label Dec 5, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 5, 2017

/morph build

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Dec 5, 2017

@0xc0170 Thanks for the quick review and build trigger.

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 5, 2017

Build : SUCCESS

Build number : 656
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5657/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Dec 5, 2017

This is patch-able BTW; it's 100% bugfix

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 32edb92 into ARMmbed:master Dec 12, 2017

10 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2 Local mbed2 testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
@phyokyaw

This comment has been minimized.

phyokyaw commented Jan 24, 2018

@theotherjimmy Thanks for the fix, I introduced this bug in #4959 when amending a second patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment