New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nordic add app_start config system support for NRF52840 for bootloader #5691

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
6 participants
@dlfryar
Contributor

dlfryar commented Dec 12, 2017

Description

Add GCC/ARM/IAR linker support for APP_START symbol in config system to support boo loaders

Status

READY

@dlfryar

This comment has been minimized.

Contributor

dlfryar commented Dec 12, 2017

Connected to #5492 this PR only addresses the 52840

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 13, 2017

@ARMmbed/team-nordic please review

#endif
#if !defined(MBED_APP_SIZE)
#define MBED_APP_SIZE 0xfffff

This comment has been minimized.

@nvlsianpu

nvlsianpu Dec 14, 2017

Contributor

This is the flash end address value, not the application size.

/*-Memory Regions-*/
define symbol __ICFEDIT_region_ROM_start__ = 0x21000;
define symbol __ICFEDIT_region_ROM_start__ = MBED_APP_START;
define symbol __ICFEDIT_region_ROM_end__ = 0xfffff;

This comment has been minimized.

@nvlsianpu

nvlsianpu Dec 14, 2017

Contributor

MBED_APP_START + MBED_APP_SIZE - 1

if (!isdefinedsymbol(MBED_APP_START)) {
define symbol MBED_APP_START = 0x21000;
}

This comment has been minimized.

@nvlsianpu

nvlsianpu Dec 14, 2017

Contributor

+if (!isdefinedsymbol(MBED_APP_SIZE)) {

  • define symbol MBED_APP_SIZE = 0xDF000;
    +}
#define MBED_APP_START 0x21000
#endif
LR_IROM1 MBED_APP_START 0xfffff {

This comment has been minimized.

@nvlsianpu

nvlsianpu Dec 14, 2017

Contributor

0xfffff MBED_APP_SIZE

This comment has been minimized.

@nvlsianpu

@0xc0170 0xc0170 added needs: work and removed needs: review labels Dec 14, 2017

@dlfryar dlfryar force-pushed the dlfryar:nrf52_linker branch from 7296328 to dc4512f Dec 14, 2017

@dlfryar

This comment has been minimized.

Contributor

dlfryar commented Dec 14, 2017

Renamed linker scripts from nrf52832 to nrf52840 and added APP_SIZE changes.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Dec 15, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 18, 2017

@nvlsianpu Please review latest changes

@dlfryar dlfryar force-pushed the dlfryar:nrf52_linker branch from dc4512f to 6569104 Dec 19, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 19, 2017

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 19, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 19, 2017

Build : SUCCESS

Build number : 721
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5691/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 20, 2017

@dlfryar Can you rebase to propagate here travis fix, all CI will be restarted and should be green

@dlfryar dlfryar force-pushed the dlfryar:nrf52_linker branch from 6569104 to 30e1e0a Dec 20, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Dec 21, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 21, 2017

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Dec 21, 2017

Previous failure was because of network license issue

        [DEBUG] Return: 1
        [DEBUG] Output: Error: C9555E: Failed to check out a license.
        [DEBUG] Output: Unable to connect to the license server. Check that ARMLMD_LICENSE_FILE is set correctly, and the license server is available.
        [DEBUG] Output: Information about this error is available at: http://ds.arm.com/support/lic56/m96|

Re-triggering build

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 21, 2017

Build : SUCCESS

Build number : 746
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5691/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 removed the needs: CI label Dec 22, 2017

@cmonr cmonr merged commit 10076bd into ARMmbed:master Dec 28, 2017

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-os-generic-context
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment