New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 : correct compilation issue with USE_FULL_ASSERT macro #5698

Merged
merged 3 commits into from Dec 20, 2017

Conversation

Projects
None yet
4 participants
@jeromecoutant
Contributor

jeromecoutant commented Dec 13, 2017

Description

Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled

Status

READY

jeromecoutant added some commits Dec 12, 2017

STM32F3 : compilation issue
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
STM32L4 : compilation issue
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled
STM32F4 : compilation issue
Issue comes only when ST HAL macro USE_FULL_ASSERT is enabled

@0xc0170 0xc0170 added the needs: CI label Dec 13, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 13, 2017

/morph build

@bcostm

bcostm approved these changes Dec 13, 2017

@@ -442,16 +442,6 @@
* @{
*/
#define COMP_WINDOWMODE_DISABLE (0x00000000U) /*!< Window mode disabled */
#define COMP_WINDOWMODE_ENABLE COMP_CSR_COMPxWNDWEN /*!< Window mode enabled: non inverting input of comparator X (x=2U,4,6U)

This comment has been minimized.

@bcostm

bcostm Dec 13, 2017

Contributor

For a better tracability don't you think we could add instead ?

// Removed for MBED
#if 0 
...
#endif
@@ -2395,8 +2385,7 @@
|| \
(((INPUT) == COMP_NONINVERTINGINPUT_IO1)))
#define IS_COMP_WINDOWMODE(WINDOWMODE) (((WINDOWMODE) == COMP_WINDOWMODE_DISABLE) || \

This comment has been minimized.

@bcostm

bcostm Dec 13, 2017

Contributor

Can we add a comment "Changed for MBED" ? Ideally adding the PR/commit number...

@@ -611,6 +611,8 @@ typedef struct __SPI_HandleTypeDef
#define IS_SPI_CRC_POLYNOMIAL(POLYNOMIAL) (((POLYNOMIAL) >= 0x1U) && ((POLYNOMIAL) <= 0xFFFFU) && (((POLYNOMIAL)&0x1U) != 0U))
#define IS_SPI_DMA_HANDLE(HANDLE) ((HANDLE) != NULL)

This comment has been minimized.

@bcostm

bcostm Dec 13, 2017

Contributor

Can we add a comment "Added for MBED" ? Ideally adding the PR/commit number...

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 13, 2017

@bcostm
No, this is not needed as patch comes from next cube version

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 13, 2017

Build : SUCCESS

Build number : 693
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5698/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Dec 13, 2017

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 897324e into ARMmbed:master Dec 20, 2017

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2 Local mbed2 testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_ST_ASSERT branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment