New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ble doxy fixes #5701

Merged
merged 5 commits into from Dec 14, 2017

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Dec 13, 2017

Description

Remove warnings issued when the BLE documentation is generated by doxygen:

  • The tag @important has been replaced by @attention.
  • Typos in parameters name and doxygen commands have been fixed.
  • Internal headers are excluded from the generation process

Status

READY

Migrations

NO

@pan-

This comment has been minimized.

Member

pan- commented Dec 13, 2017

@adbridge @AnotherButler Could you review this PR ? If it is accepted I suppose docs.json will have to be updated.

@pan- pan- force-pushed the pan-:ble-doxy-fixes branch from ac286f3 to 6d8afb4 Dec 13, 2017

@adbridge adbridge self-requested a review Dec 14, 2017

@adbridge

AFAICT looks good to me

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

All the CI was triggered, should be reported soon

@senthilr please review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 14, 2017

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 14, 2017

Build : SUCCESS

Build number : 702
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5701/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

*/features/FEATURE_COMMON_PAL/* \
*/features/FEATURE_LWIP/* \
*/features/FEATURE_UVISOR/* \
*/FEATURE_NANOSTACK/* \

This comment has been minimized.

@SenRamakri

SenRamakri Dec 14, 2017

Contributor

There is no FEATURE_NANOSTACK, should be features/nanostack. Should we be excluding the following as well?

                     */features/filesystem/* \
                     */features/frameworks/* \
                     */features/netsocket/* \
                     */features/TESTS/* \

This comment has been minimized.

@SenRamakri

SenRamakri Dec 14, 2017

Contributor

@pan- Will you be adding the above as well?

@pan-

This comment has been minimized.

Member

pan- commented Dec 14, 2017

@SenRamakri Yes there is a FEATURE_NANOSTACK. I can change it into features/nanostack if you want.

@mbed-ci

This comment has been minimized.

pan- added some commits Dec 13, 2017

Doxygen: Update excluded paths and predefined macros.
* Remove BLE feature from the list of excluded folders.
* Define the macro MBED_DEPRECATED.

@pan- pan- force-pushed the pan-:ble-doxy-fixes branch from 6d8afb4 to 51083a6 Dec 14, 2017

@pan-

This comment has been minimized.

Member

pan- commented Dec 14, 2017

@SenRamakri done.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

/morph build

@SenRamakri

Looks good now.

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 14, 2017

Build : SUCCESS

Build number : 703
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5701/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@adbridge adbridge merged commit 4d81ead into ARMmbed:master Dec 14, 2017

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2 Local mbed2 testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@adbridge adbridge removed the needs: CI label Dec 14, 2017

@pan- pan- deleted the pan-:ble-doxy-fixes branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment