New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to serial device is allowed when DEVICE_SERIAL is defined #5733

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Projects
None yet
5 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Dec 19, 2017

Access to serial_putc was not guarded under DEVICE_SERIAL define. In case DEVICE_SERIAL is not selected this will give compilation error.

Resolution was added as part of secure support, since that PR is delayed picking up mbed-os issues separately.

@0xc0170 0xc0170 added the needs: CI label Dec 20, 2017

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:non_rtos_serial_fix branch from 53dbc4f to 5bc33b9 Dec 20, 2017

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Dec 20, 2017

Rebased to get travis fix

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 20, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 20, 2017

Build : SUCCESS

Build number : 732
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5733/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph test

1 similar comment
@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Dec 27, 2017

/morph test

@mbed-ci

This comment has been minimized.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Dec 27, 2017

/morph uvisor-test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

Retesting due to timeout.

/morph uvisor-test

@adbridge adbridge merged commit 1b53aab into ARMmbed:master Dec 29, 2017

17 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:non_rtos_serial_fix branch Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment