New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lp_timer test : add a minimum delta value #5737

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented Dec 20, 2017

Description

In tests-mbed_drivers-lp_timer, since low power timer is less accurate than regular timer,
there is a delta time based on CPU clock frequency.

For ex, STM32F7 has a system core clock set to 216MHz, then delta time is only 370us.
With the current formula, we think that this delta time is too aggressive for high frequency targets.

So we propose to set a kind of minimum delta time around 500us.

Thx

Status

READY

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 20, 2017

@mprse

mprse approved these changes Dec 21, 2017

Looks good.

@@ -56,8 +56,9 @@ extern uint32_t SystemCoreClock;
#define US_PER_MSEC 1000
#define TOLERANCE_FACTOR 80000.0f
#define US_FACTOR 1000000.0f
#define CLOCK_MAX 130000000

This comment has been minimized.

@fkjagodzinski

fkjagodzinski Dec 21, 2017

Member

I think a comment based on the PR description could be added here for clarification.

This comment has been minimized.

@0xc0170

0xc0170 Dec 21, 2017

Member

how was this value chosen, why is it sufficient (based on the description, this allows to set the minimum tolerance value for targets with clock freq higher that this value)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Dec 21, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 21, 2017

I restarted uvisor, should report soon

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Dec 28, 2017

@jeromecoutant Would you mind adding in the comment, as requested in the review?

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 28, 2017

Build : SUCCESS

Build number : 767
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5737/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_LP_TIMER_TEST branch from ed8c732 to 9a43912 Jan 3, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jan 3, 2018

@cmonr
Done
Thx

@cmonr cmonr added needs: CI and removed needs: work labels Jan 3, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 3, 2018

Build : SUCCESS

Build number : 795
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5737/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 4, 2018

@theotherjimmy theotherjimmy merged commit c00efae into ARMmbed:master Jan 4, 2018

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_LP_TIMER_TEST branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment