New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #5676 make.py generates duplicate file entries in link_files.txt #5755

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
5 participants
@jorisa
Contributor

jorisa commented Dec 21, 2017

Description

Fix for #5676. In some cases relative_object_path can result in path's like "path\to.\some\file.o", which in turn can result in duplicate file names in the linker list (second entry would be in the form of "path\to\some\file.o")

Status

READY

Migrations

NO

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 21, 2017

Automatic CI verification build not done, please verify manually.

@0xc0170 0xc0170 requested a review from theotherjimmy Dec 21, 2017

@theotherjimmy

Looks good to me.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 22, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 749
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5755/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jorisa

This comment has been minimized.

Contributor

jorisa commented Dec 22, 2017

Can someone tell me why the test failed?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

Can someone tell me why the test failed?

There's one error for K64F that is known issue, and fix is already proposed. Not related to this changeset

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

The fix was integrated, restarting

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 65dd314 into ARMmbed:master Dec 28, 2017

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-os-generic-context
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the needs: CI label Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment