New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct memap path handling on windows #5775

Merged
merged 9 commits into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jan 2, 2018

Includes a parser refactor, as I got a bit irritated by seeing _gcc
suffixed method names.

Resolves #5772

Todo

  • A test for path handling
  • A test for GCC including builtin parsing
  • A test for multi-parameter cmd line parsing with IAR

theotherjimmy added some commits Jan 2, 2018

Rework parsing dispatch
Parsing dispatch now uses a metaclass as a Trait and a series of classes
that implement the trait for dispatching parsing. This structure gives
each parser it's own namespace, avoiding tacking on suffixes to each
attribute indicating which parser uses it.
@0xc0170

0xc0170 approved these changes Jan 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 3, 2018

Build : SUCCESS

Build number : 792
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5775/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@adbridge

Couple of minor comments but I wouldn't necessarily block the PR on them

for i in self.all_sections:
return value - A section name, if a new section was found, False

This comment has been minimized.

@adbridge

adbridge Jan 3, 2018

Contributor

I know you didn't add this function per se but it seems like bad programming practice to have different return types for the same return variable. E.g. Returning False implies a Boolean return type but returning a value implies something else....

This comment has been minimized.

@theotherjimmy

theotherjimmy Jan 3, 2018

Contributor

This is so extremely common in python, just with None instead of False

return '[lib]/' + object_name
return join('[lib]', test_re_obj_name.group(2),

This comment has been minimized.

@adbridge

adbridge Jan 3, 2018

Contributor

Might be good to have a comment saying what group(2) and (3) actually are ?

This comment has been minimized.

@theotherjimmy

theotherjimmy Jan 3, 2018

Contributor

I can add that.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit e301a5b into ARMmbed:master Jan 8, 2018

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@theotherjimmy theotherjimmy deleted the theotherjimmy:pathsep-memap branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment