New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC test: fix __result variable #5784

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
7 participants
@0xc0170
Member

0xc0170 commented Jan 4, 2018

Result was not defined, thus causing attribute error

AttributeError: 'RTC_time_calc_test' object has no attribute '_RTC_time_calc_test__result'

@mprse @maciejbocianski please review

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 4, 2018

Build : SUCCESS

Build number : 801
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@@ -53,6 +53,7 @@ class RTC_time_calc_test(BaseHostTest):
year_id = 0


__result = None

This comment has been minimized.

@fkjagodzinski

fkjagodzinski Jan 4, 2018

Member

Although this will fix an AttributeError, it introduces further confusion. It's unnecessary to override result() method in RTC_time_calc_test class in the first place (the device side decides if the test suite passed or not). I suggest removing result() and teardown() methods from this class altogether.

def result(self):
return self.__result
def teardown(self):
pass

This way the code gets more readable.

This comment has been minimized.

@0xc0170

0xc0170 Jan 4, 2018

Member

Was not sure what was the intention with having result method. I'll remove it, as soon as test is finished

This comment has been minimized.

@0xc0170

0xc0170 Jan 4, 2018

Member

fixed

This comment has been minimized.

@fkjagodzinski

fkjagodzinski Jan 4, 2018

Member

Side note:
From what I've seen this result() method gets called if DUT does not send {{end;success}} / {{end;failure}} which may happen e.g. on test suite timeout.

https://github.com/ARMmbed/htrun/blob/9648fd73930cfa86967833e85a0f2ef5efaf9cd5/mbed_host_tests/host_tests_runner/host_test_default.py#L467-L473

This comment has been minimized.

@0xc0170

0xc0170 Jan 4, 2018

Member

Looks correct, we are getting timeouts today, so that might needs patching as well

RTC test: fix __result variable
Not needed, neither used anywhere. Teardown also can
be removed

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_rtc_result branch from 397cc08 to 77cc7c7 Jan 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 4, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

@studavekar @kegilbert Can you please investigate the build failure? From the logs, blinky example passes, but tls example cant be fetched (OSError), that leads to all these failures

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 4, 2018

webpage mbed os problems, that are operational now. restarting

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 4, 2018

Build : SUCCESS

Build number : 805
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr cmonr self-requested a review Jan 4, 2018

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jan 4, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Jan 4, 2018

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit 954960c into ARMmbed:master Jan 8, 2018

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Jan 12, 2018

This file was only introduced in a PR which is scheduled for 5.8, thus this also needs to go to 5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment