New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enhancements for the USBHost feature and small bug fix #5800

Merged
merged 2 commits into from Jan 22, 2018

Conversation

Projects
None yet
7 participants
@abougouffa
Contributor

abougouffa commented Jan 7, 2018

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

  • Rewrite the USBHost module callbacks in the new form.
  • Fix a bug related to defining MAX_HUB_NB macro, the variable k is declared if the macro is not zero as you can see here, and after, used without testing MAX_HUB_NB which leads to undefined reference error durring compilation if MAX_HUB_NB=0.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Todos

  • Tests
  • Documentation (not needed)

Steps to test or reproduce

  • Define the MAX_HUB_NB as zero leads to a compilation error.
  • Compiling the USBHost leads to compilation warnings concerning the callbacks.
@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 7, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170 0xc0170 requested a review from c1728p9 Jan 8, 2018

@0xc0170

0xc0170 approved these changes Jan 8, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 16, 2018

Build : SUCCESS

Build number : 874
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5800/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 16, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 18, 2018

Double checking. @adbridge @0xc0170 shouldn't this PR target ARMmbed:master instead of ARMmbed:mbed-os-5.7 ?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jan 18, 2018

@cmonr Yes, we do not accept PRs against release branches...

@cmonr cmonr changed the base branch from mbed-os-5.7 to master Jan 18, 2018

@cmonr cmonr added needs: CI and removed ready for merge labels Jan 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 18, 2018

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

Restarting CI, as it did not report back

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 896
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5800/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

/morph uvisor-test

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jan 19, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 5af1d8f into ARMmbed:master Jan 22, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 22, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment