New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COMMON folder for tests #5819

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
7 participants
@geky
Member

geky commented Jan 9, 2018

see #5524 for previous discussion

A COMMON folder allows code reuse across different test cases. This avoids code duplication or code entering the application space.

The COMMON folder is uppercase to match naming conventions in Mbed OS.

I'm open to feedback, also not very familiar with the layout of the tools in Mbed OS.

resolves #5524
resolves #5803
cc @bridadan, @theotherjimmy, @0xc0170

Added COMMON folder for tests
A COMMON folder allows code reuse across different test cases. This
avoids code duplication or code enterying the application space.

The COMMON folder is uppercase to match naming conventions in Mbed OS.

@geky geky force-pushed the geky:test-common branch from 0d178d0 to d82d988 Jan 9, 2018

@geky geky added the needs: review label Jan 9, 2018

@0xc0170 0xc0170 requested review from bridadan and theotherjimmy Jan 10, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 10, 2018

A COMMON folder allows code reuse across different test cases. This avoids code duplication or code entering the application space.

+1, the pattern to match is TESTS/COMMON. What others think?

@theotherjimmy

Python changes look fine. I'll leave deciding if we want this feature up in the air for now.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Jan 12, 2018

looks good to me

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 16, 2018

Build : SUCCESS

Build number : 879
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5819/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 requested a review from studavekar Jan 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 17, 2018

@studavekar Can you please review this from testing point of view?

@studavekar

Good work @geky 👍

@cmonr cmonr merged commit 698c7d9 into ARMmbed:master Jan 18, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment