New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2+3: mbed compile, mbed test --compile, python unit tests #5848

Merged
merged 13 commits into from Feb 7, 2018

Conversation

Projects
None yet
10 participants
@theotherjimmy
Contributor

theotherjimmy commented Jan 12, 2018

Todo

  • Have Travis tests this in python 2.7, 3.5 and 3.6

@theotherjimmy theotherjimmy changed the title from Python2+3: Mbed Compile + python unit tests to Python2+3: mbed compile, mbed test --compile, python unit tests Jan 12, 2018

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:compile-py3 branch 3 times, most recently from 2d84302 to 4576a73 Jan 12, 2018

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:compile-py3 branch 5 times, most recently from 1838dd8 to 19545f4 Jan 24, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 25, 2018

@Nodraak Care to review while I work on getting testing working again?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 25, 2018

This change is huge. So will the review list:

@geky

geky approved these changes Jan 25, 2018

Travis changes look good 👍

try:
from Queue import Queue
except ImportError:
from queue import Queue

This comment has been minimized.

@sarahmarshy

sarahmarshy Jan 25, 2018

Contributor

lol

@sarahmarshy

print("Good work!")

@0xc0170

Awesome !

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 26, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 26, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 26, 2018

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jan 26, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 26, 2018

@studavekar I'm not seeing any build failures there. Am I missing something?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jan 26, 2018

@studavekar I'm not seeing any build failures there. Am I missing something?

I can see below error in console logs

00:00:40.604 mbed-os test build passed, perform example builds
00:00:40.859 usage: examples.py compile [-h] [-m MCU] [--profile profile]
00:00:40.859                            [toolchains [toolchains ...]]
00:00:40.860 examples.py compile: error: argument toolchains: invalid parse_type value: 'ARM'

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:compile-py3 branch from b639381 to 0275b6f Jan 26, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jan 26, 2018

I had to go to Jenkins for that one I suppose.

@bridadan

Great work! This is not a painless change but I'm really happy to see this happening!

@@ -154,7 +154,7 @@
test_builds = {}
total_build_success = True
for target_name, target_toolchains in build_config.iteritems():
for target_name, target_toolchains in build_config.items():

This comment has been minimized.

@bridadan

bridadan Jan 30, 2018

Contributor

Side note for this file, I'm not aware of anything that relies on this. It'd be good to double check that but I'm guessing this file could be removed in the future.

SUPPORTED_TOOLCHAINS = ["ARM", "IAR", "GCC_ARM", "ARMC6"]
SUPPORTED_TOOLCHAINS = list(TOOLCHAINS - set(u'uARM'))

This comment has been minimized.

@bridadan

bridadan Jan 30, 2018

Contributor

👍

@geky

This comment has been minimized.

Member

geky commented Jan 30, 2018

Sorry, pretty bars made it in first. Looks like this will need a rebase. 😛

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:compile-py3 branch from 0275b6f to 2d50a90 Feb 5, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 5, 2018

Done.
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 5, 2018

Build : SUCCESS

Build number : 1065
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5848/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 5, 2018

/morph uvisor-test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 5, 2018

/morph uvisor-test

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 5, 2018

/morph uvisor-test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 5, 2018

/morph uvisor-test

@cmonr cmonr added ready for merge and removed needs: work labels Feb 6, 2018

@cmonr cmonr merged commit c679dee into ARMmbed:master Feb 7, 2018

17 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 7, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Feb 23, 2018

This relies on changes introduced in #5022 which is targeted for 5.8.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 23, 2018

@adbridge It's not that it "relies on" it, it was just rebased on top of those changes, and modified the same code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment