New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 LPT optimisation #5862

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
4 participants
@jeromecoutant
Contributor

jeromecoutant commented Jan 16, 2018

Description

For each low power timer/ticker start, lp_ticker_read function is called 3 or 4 times.
lp_ticker_read duration was around 58us.
It is now reduced to 9us.

Hope it will solve #5790

Status

READY

@@ -123,6 +124,10 @@ void rtc_init(void)
RtcHandle.Init.OutPutType = RTC_OUTPUT_TYPE_OPENDRAIN;
#endif /* TARGET_STM32F1 */
#if DEVICE_LOWPOWERTIMER && !MBED_CONF_TARGET_LOWPOWERTIMER_LPTIM
lp_TickPeriod_us = 2048 * 1000000 / RtcHandle.Init.SynchPrediv;

This comment has been minimized.

@0xc0170

0xc0170 Jan 16, 2018

Member

where is 2048 coming from ? would it make sense to have a macro here with name that would explain ?

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 16, 2018

Contributor

Done, thx

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_LPT_ISSUE branch from d9ebe30 to 9fb865a Jan 16, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 16, 2018

Build : SUCCESS

Build number : 878
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5862/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 16, 2018

@0xc0170 0xc0170 merged commit c24eb5b into ARMmbed:master Jan 18, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_LPT_ISSUE branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment