New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoAP v4.1.1 #5864

Merged
merged 4 commits into from Jan 23, 2018

Conversation

Projects
None yet
8 participants
@JaniSuonpera
Contributor

JaniSuonpera commented Jan 17, 2018

This includes check Entity Too Large check for block1 and request server to resend data with supported block size.

New API to control whether coap itself sends a next GET(block2) request or not
Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference

Status

*READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

@JaniSuonpera

This comment has been minimized.

Contributor

JaniSuonpera commented Jan 17, 2018

@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Jan 17, 2018

LGTM

@0xc0170 0xc0170 requested review from anttiylitokola and yogpan01 Jan 17, 2018

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Jan 17, 2018

@JaniSuonpera Please add this to the git commit message for clear description of what this PR fixes

This PR implement https://tools.ietf.org/html/rfc7959#section-2.5
"The error code 4.13 (Request Entity Too Large) can be returned at any
time by a server that does not currently have the resources to store
blocks for a block-wise request payload transfer that it would intend
to implement in an atomic fashion. (Note that a 4.13 response to a
request that does not employ Block1 is a hint for the client to try
sending Block1, and a 4.13 response with a smaller SZX in its Block1
Option than requested is a hint to try a smaller SZX.)

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Jan 17, 2018

@adbridge adbridge added needs: work and removed needs: review labels Jan 17, 2018

Jani Suonpera
Update CoAP to 4.0.11
This PR implement https://tools.ietf.org/html/rfc7959#section-2.5
"The error code 4.13 (Request Entity Too Large) can be returned at any
time by a server that does not currently have the resources to store
blocks for a block-wise request payload transfer that it would intend
to implement in an atomic fashion. (Note that a 4.13 response to a
request that does not employ Block1 is a hint for the client to try
sending Block1, and a 4.13 response with a smaller SZX in its Block1
Option than requested is a hint to try a smaller SZX.)

@JaniSuonpera JaniSuonpera force-pushed the JaniSuonpera:CoAP_v4.0.11 branch from e0b3edb to fe80b67 Jan 17, 2018

@0xc0170 0xc0170 added needs: review and removed needs: work labels Jan 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 17, 2018

PR updated, please review the latest addition

@JaniSuonpera

This comment has been minimized.

Contributor

JaniSuonpera commented Jan 18, 2018

There is coming fix. Small regression detected with internal testing.

anttiylitokola and others added some commits Jan 17, 2018

mbed-coap update to version 4.1.0
 - New API to control whether coap itself sends a next GET(block2) request or not
 - Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference
Jani Suonpera
Update CoAP to 4.1.1
Combined CoAP changes 4.0.11 and 4.1.0
Fixed regression with 4.0.11

@JaniSuonpera JaniSuonpera changed the title from CoAP v4.0.11 to CoAP v4.1.1 Jan 18, 2018

@JaniSuonpera

This comment has been minimized.

Contributor

JaniSuonpera commented Jan 19, 2018

This contains now PR #5865

@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Jan 19, 2018

@JaniSuonpera, please update the changelog as well.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

This contains now PR #5865

Can that one be closed and we proceed this one?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 897
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5864/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@JaniSuonpera

This comment has been minimized.

Contributor

JaniSuonpera commented Jan 19, 2018

I think that we can close PR #5865.

@mbed-ci

This comment has been minimized.

Jani Suonpera
@JaniSuonpera

This comment has been minimized.

Contributor

JaniSuonpera commented Jan 22, 2018

Changelog file updated.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 22, 2018

/morph build

@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Jan 22, 2018

@0xc0170, When will be the next mbed-os release and can we get this fix included?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 22, 2018

@0xc0170, When will be the next mbed-os release and can we get this fix included?

The next week. Yes, waiting for CI to be completed

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 22, 2018

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Jan 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 22, 2018

Build : SUCCESS

Build number : 906
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5864/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8e683d5 into ARMmbed:master Jan 23, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment