New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTX idle: sleep without locked deep sleep fix #5866

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
7 participants
@0xc0170
Member

0xc0170 commented Jan 17, 2018

I could not find a reason from the logs why this locking was present if tickless is enabled.

Please review

RTX idle: sleep without locked deep sleep fix
If tickless is enabled, it should not be locking deepsleep

@0xc0170 0xc0170 requested review from bulislaw and c1728p9 Jan 17, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jan 17, 2018

Maybe because os_timer is not a lp_timer, so tick count is stopped during deepsleep ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 17, 2018

Maybe because os_timer is not a lp_timer, so tick count is stopped during deepsleep ?

os timer is lp ticker by default

This is more related to how fast can a target wake up from deep sleep, not defined for the current version (see sleep feature branch). Therefore this should stay as it is. But the documentation should state this limitation that even with tickless mode, we only sleep for now

I read some bug reports regarding sleep (2 reports within the last days ) and was notified about sleep manager confusion between docs and code.

To resolve this, this code change is not accepted, and we will update Handbook to add a description about the sleep manager in the idle loop? Let me know what you think, I can send Handbook update

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 17, 2018

https://os.mbed.com/docs/v5.7/reference/sleep-manager.html - this is the handbook sleep manager page
Example 1 there:

    // Sleep for 1 second
    printf("Deep sleep allowed: %i\r\n", sleep_manager_can_deep_sleep());
    wait(1.0);

Eventhough deep sleep is enabled in the main app, it would not deepsleep.

@bulislaw

I can't think about anything neither. If it passes all the tests then we are OK.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 22, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jan 22, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 22, 2018

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Jan 22, 2018

/morph build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 22, 2018

Build : SUCCESS

Build number : 913
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5866/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 23, 2018

Jenkins didn't report abort.

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 23, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 23, 2018

Eclipse error after cleaning up the workspace

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit eb2f4ae into ARMmbed:master Jan 23, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment