New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpc546xx and ff_lpc546xx: create parent object MCU_LPC546XX #5876

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
5 participants
@gorazdko
Contributor

gorazdko commented Jan 17, 2018

Abstract

ff_lpc546xx currently inherits from target lpc546xx. This results in error in mbed online compiler:

Error: Library name 'platform' is not unique (defined in '/extras/mbed_7130f322cb7e/TARGET_LPC546XX/mbed_lib.json' and '/extras/mbed_7130f322cb7e/TARGET_FF_LPC546XX/mbed_lib.json')

when compiling examples with mbed library (compiling with mbed-os works fine).

Status: READY

Priority: High

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 17, 2018

Automatic CI verification build not done, please verify manually.

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Jan 17, 2018

"FF_LPC546XX": {
"inherits": ["LPC546XX"],
"inherits": ["MCU_LPC546XX"],
"extra_labels_add" : ["LPC546XX"],

This comment has been minimized.

@0xc0170

0xc0170 Jan 18, 2018

Member

Why is this label needed and not present in the parent, neither LPC546XX does need it?

This comment has been minimized.

@gorazdko

gorazdko Jan 18, 2018

Contributor

fixed, both targets need it (target LPC546XX adds it by default)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 18, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 18, 2018

ff_lpc546xx currently inherits from target lpc546xx. This results in error in mbed online compiler:

Still causing the problems with the latest update?

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Jan 19, 2018

It doesnt work with mbed version 157.

I havent tested 242ce29 against the error. How do i point online compiler to it?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 19, 2018

I havent tested 242ce29 against the error. How do i point online compiler to it?

you can fork mbed-os there and use your own modified version for instance

gorazdko added a commit to gorazdko/mbed that referenced this pull request Jan 19, 2018

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Jan 19, 2018

you can fork mbed-os there and use your own modified version for instance

yes i am familiar with that. Although i need to fork mbed (not mbed-os). So i need to fork this with source files. Where is the fork button?
If i import it into compiler and fork from there it only forks precompiled build (no source).

Anyway, i moved the mbed repo to github and imported the lib from there. This PR does not solve the error:

fix_not_working

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Jan 19, 2018

Changing device name does not work either:
mbed_3

It does work if i remove or rename the LPC546XX folder:
mbed_5

I am closing this PR and opening an issue for that.

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 5, 2018

User not whitelisted, CI not run.

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Feb 5, 2018

Reopening this PR. See #5887.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 5, 2018

/morph build

@0xc0170

0xc0170 approved these changes Feb 5, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 5, 2018

Build : SUCCESS

Build number : 1060
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5876/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 5, 2018

network error for one device, restarting

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 5, 2018

@gorazdko This is going to need a rebase to resolve a conflict.

Fixes #5887

@cmonr cmonr added the needs: work label Feb 5, 2018

@mbed-ci

This comment has been minimized.

@gorazdko gorazdko force-pushed the gorazdko:ff-lpc546xx-modify-target branch from 242ce29 to 8593ca6 Feb 6, 2018

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Feb 6, 2018

rebased

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 6, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 6, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 6, 2018

Build : SUCCESS

Build number : 1070
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5876/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 6, 2018

@cmonr cmonr merged commit 2d05258 into ARMmbed:master Feb 6, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment