New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the murata's module CMWX1ZZABZ-078 based on STM32L0 #5905

Merged
merged 1 commit into from Jan 31, 2018

Conversation

Projects
None yet
7 participants
@ithinuel
Member

ithinuel commented Jan 23, 2018

Description

This PR add support for the STM32L082CZ and murata's CMWX1ZZABZ-078 module.
This was tested with @kivaisan on mbed-os-example-lora

Status

WORK IN PROGRESS

Related PR

Todos

  • Tests
  • Documentation
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 23, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 23, 2018

@ithinuel mbed test results from all 3 toolchains?

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 23, 2018

Build : SUCCESS

Build number : 923
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@jeromecoutant

Hi
Here is a quick review :-)

.gitignore Outdated
@@ -72,6 +72,9 @@ debug.log
# Cscope
cscope.*
# Ctags
tags

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 23, 2018

Contributor

not related to the PR ?

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

No indeed, does it need to have its own PR ?

This comment has been minimized.

@cmonr

cmonr Jan 23, 2018

Contributor

Yes please. I know it seems small, but it helps in keeping pull requests atomic and relevant to their subject.

This comment has been minimized.

@cmonr

cmonr Jan 23, 2018

Contributor

Feel free to reference this PR to indicate that it's related.

@@ -0,0 +1,239 @@
;******************** (C) COPYRIGHT 2016 STMicroelectronics ********************
;* File Name : startup_stm32l053xx.s

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 23, 2018

Contributor

wrong file

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

fixed (removed)

@@ -0,0 +1,44 @@
; Scatter-Loading Description File
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 23, 2018

Contributor

wrong file

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

fixed (removed)

@@ -0,0 +1,44 @@
; Scatter-Loading Description File
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 23, 2018

Contributor

wrong file name

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

fixed (removed)

"core": "Cortex-M0+",
"extra_labels_add": ["STM32L0", "STM32L0x2xB", "STM32L082KB", "STM32L082xx"],
"detect_code": [],
"device_has_add": ["ANALOGOUT", "LOWPOWERTIMER", "SERIAL_FC", "SERIAL_ASYNCH", "TRNG", "FLASH"],

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 23, 2018

Contributor

Add macro MBEDTLS_CONFIG_HW_SUPPORT ?

This comment has been minimized.

@ithinuel

This comment has been minimized.

@ithinuel

ithinuel Jan 24, 2018

Member

Actually not as AES driver does not support STM32L0x2 yet.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: work and removed needs: CI labels Jan 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 23, 2018

It's a tiny change, but holding off on another rebuild until .gitignore is restored. .gitignore change is not related to PR.

@mbed-ci

This comment has been minimized.

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jan 24, 2018

I have a remark about the subfolder name TARGET_STM32L0x2xB.

You wrote in the PR description that this module is based on the STM32L082CZ MCU. So, I think it would be better to use TARGET_STM32L082xZ in order to be aligned with the other targets.

If it is a mistake and the MCU is a STM32L082CB, I would use TARGET_STM32L082xB.

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 24, 2018

@bcostm Actually this is intended.
This is to match the 072 & 082 as they only differ by the presence of an AES hw on the 082.
The memory range does not collide with other as they are identified by the last letter "B" of the 128K/20K range. So any target based on l072xB or L082xB within this directory share the same code.
for reference : stm32l0x2 USB line

@cmonr Ok, I remove it

@0xc0170 I couldn't run them yet as I miss the DAPLink support for this soc.

@ithinuel ithinuel force-pushed the ithinuel:add-CMWX1ZZABZ-078-support branch from edb4b03 to c3f9b29 Jan 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Build : SUCCESS

Build number : 941
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@ithinuel ithinuel force-pushed the ithinuel:add-CMWX1ZZABZ-078-support branch from c3f9b29 to 06f7007 Jan 25, 2018

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 25, 2018

Update: rebase + rename from stm32l0x2xB to stm32l0x2xZ + disable LOWPOWERTIM as some tests were not passing.

compiler result
GCC
ARMC6
ARMC5 I cannot test
IAR I cannot test
@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jan 26, 2018

Hi

Just a comment on:

disable LOWPOWERTIM as some tests were not passing

I think disabling LPT for a Lora board doesn't have any sense...
System clock is using HSI which is a low precise clock, timers are then not precise, and tests become FAIL...

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 26, 2018

@jeromecoutant Enabling LPT actually requires LSE/LSI and I couldn't get tests to pass with them.
Couldn't this be part of a further issue/pr ?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jan 26, 2018

Enabling LPT actually requires LSE/LSI and I couldn't get tests to pass with them.

Yes, LPT is using LSE from Murata module.
System timer is using HSI from STM32 chip (tests are using system timer to check lp timer).

Couldn't this be part of a further issue/pr ?

It is up to you, it's your board :-)

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 26, 2018

This PR needs #5937

@ithinuel ithinuel force-pushed the ithinuel:add-CMWX1ZZABZ-078-support branch from 06f7007 to d3bf2fd Jan 26, 2018

@ithinuel ithinuel force-pushed the ithinuel:add-CMWX1ZZABZ-078-support branch from d3bf2fd to f8e88d7 Jan 26, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 26, 2018

Build : SUCCESS

Build number : 974
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr cmonr added needs: CI and removed needs: work labels Jan 26, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 26, 2018

@ithinuel In that case, can you rebase this PR so we can rebuild?

@cmonr cmonr added needs: work and removed needs: CI labels Jan 26, 2018

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 26, 2018

@cmonr It is already rebased & built but it seems I still have issue with the exporter of uvision.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 26, 2018

@ithinuel Looks like this is an issue on our side.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 26, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 29, 2018

@ithinuel Looks like this is an issue on our side.

@studavekar Can you please check the latest exporters failure here?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 29, 2018

@ithinuel, we're currently working to resolve this on our side.

Once it's resolved, we'll relaunch the export build.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jan 29, 2018

@cmonr @0xc0170 can you please provide the link to cmsis pack which needs to be installed?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jan 29, 2018

Thanks, @cmonr. Have installed required pack for CMWX1ZZABZ

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 30, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: work labels Jan 31, 2018

@cmonr cmonr merged commit 097966b into ARMmbed:master Jan 31, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 31, 2018

@ithinuel ithinuel deleted the ithinuel:add-CMWX1ZZABZ-078-support branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment