New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CriticalSectionLock: fixing missing include #5912

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
4 participants
@MikeDK
Contributor

MikeDK commented Jan 24, 2018

Description

Macro MBED_DEPRECATED_SINCE is defined in platform/mbed_toolchain.h which was not included.
If someone used member functions lock or unlock (which are prefixed with MBED_DEPRECATED_SINCE since some time), there would be a compile error instead of a warning.
Including mbed_toolchain.h fixes that.

Status

READY

Steps to test or reproduce

Use CriticalSectionLock.lock() in a cpp file where CriticalSectionLock.h is included before mbed.h - compile error will occur.

CriticalSectionLock: fixing missing include
Macro MBED_DEPRECATED_SINCE is defined in platform/mbed_toolchain.h which was not included.
If someone used member functions lock or unlock (which are prefixed with MBED_DEPRECATED_SINCE since some time), there would be a compile error instead of a warning.
Including mbed_toolchain.h fixes that.
@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jan 24, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Build : SUCCESS

Build number : 927
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5912/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

seems like some test hardware failed to sync

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

Am I able to trigger the tests? Or do only members have the permissions to do the /morph build ? :)

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

/morph build

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

Ok, I answered the question to myself :P

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 25, 2018

Ok, I answered the question to myself :P

We will retrigger CI, there is known issue with one device (not related to this PR), fix is already under tests

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

yeah I experience the same issue here with my NUCLEO-F746ZG board ... It is stuck somewhere before entering my application code.
When I revert the commit 4c07c1c (Merge pull request #5821 from bcostm/add_BL_nucleo-f746zg), everything works again.

As I own such a board - can I be of any help fixing the issue? ;)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 25, 2018

As I own such a board - can I be of any help fixing the issue? ;)

Any help appreciated 👍 Thanks for confirming the issue !
We currently have a revert under test #5927, and the addition needs to be retested and fixed

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

I already found that revert and tested it ... just to realize it only reverts the changes for NUCLEO_F767ZI ... but the issue is also present on the NUCLEO_F746ZG (which I own)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 25, 2018

@MikeDK Correct, F7 cache settings needs to be reverted, here #5932

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Jan 25, 2018

Ok I just tested #5932, and I can confirm that it fixes the problem

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 25, 2018

Build : SUCCESS

Build number : 947
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5912/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 26, 2018

@cmonr cmonr merged commit b67b69e into ARMmbed:master Jan 26, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 26, 2018

@MikeDK MikeDK deleted the MikeDK:critical_section_lock_fix branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment