New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EFM32 HAL flash init/deinit function calls #5913

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
5 participants
@DBS06

DBS06 commented Jan 24, 2018

Description

Add MSC_Init()/MSC_Deinit() to flash_init()/flash_free() in flash_api.c for TARGET_EFM32. This allows using the FLASH IAP without calling the EFM32 HAL MSC_Init()/MSC_Deinit() functions in the application code.
This increases also the portability of the application code.
Furthermore the using of the FLASH IAP is more straight forward, because the writing and erasing functions in flash_api.c do not throw an error when they are not initialized.

Status

READY

Migrations

NO

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

@ARMmbed/team-silabs Please review

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jan 24, 2018

LGTM 👍

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Build : SUCCESS

Build number : 931
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5913/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 25, 2018

Build : SUCCESS

Build number : 945
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5913/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 26, 2018

@cmonr cmonr merged commit ce87bda into ARMmbed:master Jan 26, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment