New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and Improve error/warning parser for gcc_arm #5915

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
5 participants
@DBS06

DBS06 commented Jan 24, 2018

Description

Simplify parsing of error and warning messages for GCC_ARM.

First, the parsing method is a little bit confusing and hacky and sometimes the column parsing by calculating the ^ position fails and on the output it shows "0" instead of the correct warning/error column. Instead I am parsing the column out of the gcc_arm output.
Second, the regex for the "INDEX_PATTERN" is not necessary anymore.

Status

READY

Migrations

NO

Steps to test or reproduce

mbed compile -t GCC_ARM --profile release
note: mcu (TARGET) must/should be configured in ".mbed"

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 24, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

@0xc0170 0xc0170 removed the needs: review label Jan 24, 2018

@DBS06

This comment has been minimized.

DBS06 commented Jan 24, 2018

Hi, I signed, I thought the pdf per mail was enough

@0xc0170 0xc0170 added needs: review and removed needs: work labels Jan 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 1, 2018

@theotherjimmy Think you could take a quick look at this?

@theotherjimmy theotherjimmy changed the title from Simplify and Improve error/warning parser for arm_gcc to Simplify and Improve error/warning parser for gcc_arm Feb 2, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

I think the old style of parsing was done to skip over lines and find the ^ character indicating the column number of the error. I don't think this new regex does the same thing. Could you show an example of it parsing a multi-line error before and after?

The new code just reads that from the line, doesn't it?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

note: mcu (TARGET) must/should be configured in ".mbed"

note: mcu can be provided on the CLI with -m.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 2, 2018

as this must be profile agnostic, why did you include --profile release in the command line? is that required?

@theotherjimmy

Supposing this is confirmed to work with more than --profile release (it should, I just want to check)

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 7, 2018

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 7, 2018

as this must be profile agnostic, why did you include --profile release in the command line? is that required?

@DBS06 How did you test (all profiles) ?

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 7, 2018

Build : SUCCESS

Build number : 1086
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5915/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 7, 2018

Waiting on reply from @DBS06

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 19, 2018

Passed all tests, green

@0xc0170 0xc0170 merged commit 636ced8 into ARMmbed:master Feb 19, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment