New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenOCD 5x launch file to e2 studio and update naming #5933

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
6 participants
@phyokyaw

phyokyaw commented Jan 25, 2018

Description

We have a Open OCD lunch file included in the exporter template. However Open OCD ID has changed

from gnuarmeclipse to gnumcueclipse. Hence this patch adds updates to existing launch file with new ID and also kept the old launch file for e2 studio 5.x compatibility.

Status

READY

Migrations

NO

Steps to test or reproduce

Export a project to e2 studio and import in e2 studio 6.x. Launch file doesn't appear on debug configurations dialog.

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 25, 2018

Automatic CI verification build not done, please verify manually.

@phyokyaw

This comment has been minimized.

phyokyaw commented Jan 25, 2018

@theotherjimmy Please review if possible. Thank you.

@0xc0170 0xc0170 requested a review from theotherjimmy Jan 25, 2018

@theotherjimmy

Looks good.

@theotherjimmy theotherjimmy changed the title from Updated exporter for e2 studio with new launch file for Open OCD to Add OpenOCD 5x launch file to e2 studio and update naming Jan 25, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Jan 25, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 25, 2018

/morph build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 26, 2018

Build : SUCCESS

Build number : 968
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5933/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 26, 2018

Odd. Result didn't report back.
/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 29, 2018

@cmonr cmonr merged commit 6da5d54 into ARMmbed:master Jan 29, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment